You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/19 13:28:14 UTC

[GitHub] [flink] hequn8128 opened a new pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

hequn8128 opened a new pull request #13199:
URL: https://github.com/apache/flink/pull/13199


   
   ## What is the purpose of the change
   
   This pull request adds documentation for DataTypes in Python DataStream API
   
   
   ## Brief change log
   
     - Add index page for the Python DataStream Doc.
     - Add documentation for DataTypes under the index page of Python DataStream Doc.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676387876


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5713",
       "triggerID" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c2d450efbdda3b25cafa41cc5b1323ab43630a38",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c2d450efbdda3b25cafa41cc5b1323ab43630a38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a5329b994ede3de3bc97855a2dc6b302d92bd7b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5713) 
   * c2d450efbdda3b25cafa41cc5b1323ab43630a38 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676387876


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a5329b994ede3de3bc97855a2dc6b302d92bd7b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676387876


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5713",
       "triggerID" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a5329b994ede3de3bc97855a2dc6b302d92bd7b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5713) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 commented on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676369504


   CC @sjwiesman @shuiqiangchen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676362453


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9a5329b994ede3de3bc97855a2dc6b302d92bd7b (Wed Aug 19 13:31:21 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 commented on a change in pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #13199:
URL: https://github.com/apache/flink/pull/13199#discussion_r473127638



##########
File path: docs/dev/python/user-guide/datastream/index.md
##########
@@ -0,0 +1,32 @@
+---
+title: "DataStream API"
+nav-id: python_datastream_api
+nav-parent_id: python_user_guide
+nav-pos: 30
+nav-show_overview: true

Review comment:
       ok, we can add this after all content are ready.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676387876


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5713",
       "triggerID" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c2d450efbdda3b25cafa41cc5b1323ab43630a38",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5716",
       "triggerID" : "c2d450efbdda3b25cafa41cc5b1323ab43630a38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c2d450efbdda3b25cafa41cc5b1323ab43630a38 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5716) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 merged pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #13199:
URL: https://github.com/apache/flink/pull/13199


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on a change in pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #13199:
URL: https://github.com/apache/flink/pull/13199#discussion_r473290103



##########
File path: docs/dev/python/user-guide/datastream/data_types.md
##########
@@ -0,0 +1,114 @@
+---
+title: "Data Types"
+nav-parent_id: python_datastream_api
+nav-pos: 10
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+In Apache Flink's Python DataStream API, a data type describes the type of a value in the DataStream ecosystem. 
+It can be used to declare input and output types of operations and informs the system how to serailize elements. 
+
+* This will be replaced by the TOC
+{:toc}
+
+
+## Pickle Serialization
+If the type has not been declared, data would be serialized or deserialized using Pickle. 

Review comment:
       ```suggestion
   ## Pickle Serialization
   
   If the type has not been declared, data would be serialized or deserialized using Pickle. 
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on a change in pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #13199:
URL: https://github.com/apache/flink/pull/13199#discussion_r473066461



##########
File path: docs/dev/python/user-guide/datastream/data_types.zh.md
##########
@@ -0,0 +1,116 @@
+---
+title: "Data Types"
+nav-parent_id: python_datastream_api
+nav-pos: 10
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+* This will be replaced by the TOC
+{:toc}
+
+
+## Why need Data Types
+
+In Python DataStream, a data type describes the type of a value in the DataStream ecosystem. 
+It can be used to declare input and/or output types of operations. 
+Similar to Python, you don't require to specify types for the parameters of a Function in Python DataStream. 
+If the type has not been declared, data would be serialized or deserialized using Pickle. 
+For example, the program below specifies no data types.
+
+{% highlight python %}
+from pyflink.datastream import StreamExecutionEnvironment
+
+
+def processing():
+    env = StreamExecutionEnvironment.get_execution_environment()
+    env.set_parallelism(1)
+    env.from_collection(collection=[(1, 'aaa'), (2, 'bbb')]) \
+        .map(lambda record: (record[0]+1, record[1].upper())) \
+        .print()  # note: print to stdout on the worker machine
+
+    env.execute()
+
+
+if __name__ == '__main__':
+    processing()
+{% endhighlight %}
+
+However, types need to be specified when:
+
+- Passing Python records to Java operations.
+- Improve serialization and deserialization performance.
+
+### Passing Python records to Java operations
+
+Since Java operators or functions can not identify Python data, types need to be provided to help to convert Python data to Java data for processing.
+For example, types need to be provided if you want to output data from the map into the StreamingFileSink. 
+The StreamingFileSink is actually implemented by Java for the runtime part. 

Review comment:
       ```suggestion
   Since Java operators or functions can not identify Python data, types need to be provided to help to convert Python types to Java types for processing.
   For example, types need to be provided if you want to output data using the StreamingFileSink which is implemented in Java.
   ```

##########
File path: docs/dev/python/user-guide/datastream/data_types.zh.md
##########
@@ -0,0 +1,116 @@
+---
+title: "Data Types"
+nav-parent_id: python_datastream_api
+nav-pos: 10
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+* This will be replaced by the TOC
+{:toc}
+
+
+## Why need Data Types
+
+In Python DataStream, a data type describes the type of a value in the DataStream ecosystem. 
+It can be used to declare input and/or output types of operations. 
+Similar to Python, you don't require to specify types for the parameters of a Function in Python DataStream. 
+If the type has not been declared, data would be serialized or deserialized using Pickle. 
+For example, the program below specifies no data types.

Review comment:
       ```suggestion
   In Apache Flink's Python DataStream API, a data type describes the type of a value in the DataStream ecosystem. 
   It can be used to declare input and output types of operations and informs the system how to serailize elements. 
   
   * This will be replaced by the TOC
   {:toc}
   
   
   ## Pickle Serialization
   
   If the type has not been declared, data would be serialized or deserialized using Pickle. 
   For example, the program below specifies no data types.
   ```

##########
File path: docs/dev/python/user-guide/datastream/data_types.zh.md
##########
@@ -0,0 +1,116 @@
+---
+title: "Data Types"
+nav-parent_id: python_datastream_api
+nav-pos: 10
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+* This will be replaced by the TOC
+{:toc}
+
+
+## Why need Data Types
+
+In Python DataStream, a data type describes the type of a value in the DataStream ecosystem. 
+It can be used to declare input and/or output types of operations. 
+Similar to Python, you don't require to specify types for the parameters of a Function in Python DataStream. 
+If the type has not been declared, data would be serialized or deserialized using Pickle. 
+For example, the program below specifies no data types.
+
+{% highlight python %}
+from pyflink.datastream import StreamExecutionEnvironment
+
+
+def processing():
+    env = StreamExecutionEnvironment.get_execution_environment()
+    env.set_parallelism(1)
+    env.from_collection(collection=[(1, 'aaa'), (2, 'bbb')]) \
+        .map(lambda record: (record[0]+1, record[1].upper())) \
+        .print()  # note: print to stdout on the worker machine
+
+    env.execute()
+
+
+if __name__ == '__main__':
+    processing()
+{% endhighlight %}
+
+However, types need to be specified when:
+
+- Passing Python records to Java operations.
+- Improve serialization and deserialization performance.
+
+### Passing Python records to Java operations
+
+Since Java operators or functions can not identify Python data, types need to be provided to help to convert Python data to Java data for processing.
+For example, types need to be provided if you want to output data from the map into the StreamingFileSink. 
+The StreamingFileSink is actually implemented by Java for the runtime part. 
+
+{% highlight python %}
+from pyflink.common.serialization import SimpleStringEncoder
+from pyflink.common.typeinfo import Types
+from pyflink.datastream import StreamExecutionEnvironment
+from pyflink.datastream.connectors import StreamingFileSink
+
+
+def streaming_file_sink():
+    env = StreamExecutionEnvironment.get_execution_environment()
+    env.set_parallelism(1)
+    env.from_collection(collection=[(1, 'aaa'), (2, 'bbb')]) \
+        .map(lambda record: (record[0]+1, record[1].upper()),
+             result_type=Types.ROW([Types.INT(), Types.STRING()])) \
+        .add_sink(StreamingFileSink
+                  .for_row_format('/tmp/output', SimpleStringEncoder())
+                  .build())
+
+    env.execute()
+
+
+if __name__ == '__main__':
+    streaming_file_sink()
+
+{% endhighlight %}
+
+### Improve serialization and deserialization performance
+
+Even though data can be serialized and deserialized through Pickle, the performance should be better if types are provided. 
+This is because PyFlink can use more efficient serializers and deserializers to serialize and deserialize data.

Review comment:
       ```suggestion
   Even though data can be serialized and deserialized through Pickle, performance will be better if types are provided.
   Explicit types allow PyFlink to use efficient serializers when moving records through the pipeline.
   ```

##########
File path: docs/dev/python/user-guide/datastream/index.md
##########
@@ -0,0 +1,32 @@
+---
+title: "DataStream API"
+nav-id: python_datastream_api
+nav-parent_id: python_user_guide
+nav-pos: 30
+nav-show_overview: true

Review comment:
       I don't think we need this page. Let's revisit this after the rest of the content is merged in. 

##########
File path: docs/dev/python/user-guide/datastream/index.md
##########
@@ -0,0 +1,32 @@
+---
+title: "DataStream API"
+nav-id: python_datastream_api
+nav-parent_id: python_user_guide
+nav-pos: 30
+nav-show_overview: true

Review comment:
       ```suggestion
   ```

##########
File path: docs/dev/python/user-guide/datastream/index.md
##########
@@ -0,0 +1,32 @@
+---
+title: "DataStream API"
+nav-id: python_datastream_api
+nav-parent_id: python_user_guide
+nav-pos: 30
+nav-show_overview: true
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+Python DataStream API allows users to develop [DataStream API]({{ site.baseurl }}/dev/datastream_api.html) programs using the Python language.
+Apache Flink has provided Python DataStream API support since 1.12.0.
+
+## Where to go next?
+
+- [Data Types]({{ site.baseurl }}/dev/python/user-guide/datastream/data_types.html): Lists the supported data types in Python DataStream API.

Review comment:
       ```suggestion
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 commented on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676512311


   @sjwiesman I have updated the PR. Thanks a lot for your review and suggestions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676387876


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5713",
       "triggerID" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c2d450efbdda3b25cafa41cc5b1323ab43630a38",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5716",
       "triggerID" : "c2d450efbdda3b25cafa41cc5b1323ab43630a38",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a5329b994ede3de3bc97855a2dc6b302d92bd7b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5713) 
   * c2d450efbdda3b25cafa41cc5b1323ab43630a38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5716) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676387876


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5713",
       "triggerID" : "9a5329b994ede3de3bc97855a2dc6b302d92bd7b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a5329b994ede3de3bc97855a2dc6b302d92bd7b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5713) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 commented on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on pull request #13199:
URL: https://github.com/apache/flink/pull/13199#issuecomment-676847061


   @sjwiesman @shuiqiangchen Thanks a lot for the review. The comments have all been addressed.
   
   Merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org