You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/20 13:37:28 UTC
[GitHub] [iotdb] OneSizeFitsQuorum commented on a change in pull request #5289: [IOTDB-2761] Data node internal thrift service for config node
OneSizeFitsQuorum commented on a change in pull request #5289:
URL: https://github.com/apache/iotdb/pull/5289#discussion_r830617119
##########
File path: thrift-datanode/src/main/thrift/datanode.thrift
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+include "rpc.thrift"
+namespace java org.apache.iotdb.service.rpc.thrift
+namespace py iotdb.thrift.rpc
+
+typedef i32 int
+typedef i64 long
+
+struct CreateSchemaRegionReq {
+ 1: required list<int> DataNodeID
Review comment:
Use the same naming method, do not capitalize the first letter
##########
File path: thrift-datanode/src/main/thrift/datanode.thrift
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+include "rpc.thrift"
+namespace java org.apache.iotdb.service.rpc.thrift
+namespace py iotdb.thrift.rpc
+
+typedef i32 int
+typedef i64 long
+
+struct CreateSchemaRegionReq {
+ 1: required list<int> DataNodeID
+ 2: required int schemaRegionID
+}
+
+struct CreateDataRegionReq {
+ 1: required list<int> DataNodeID
Review comment:
same as above
##########
File path: thrift-datanode/src/main/thrift/datanode.thrift
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+include "rpc.thrift"
+namespace java org.apache.iotdb.service.rpc.thrift
+namespace py iotdb.thrift.rpc
+
+typedef i32 int
+typedef i64 long
+
+struct CreateSchemaRegionReq {
+ 1: required list<int> DataNodeID
+ 2: required int schemaRegionID
+}
+
+struct CreateDataRegionReq {
+ 1: required list<int> DataNodeID
+ 2: required int dataRegionID
+}
+
+struct CreateDataPartitionReq{
+ 1: required list<int> DataNodeID
+ 2: required int dataRegionID
+ 3: required long timeInterval
+}
+
+struct MigrateSchemaRegionReq{
+ 1: required int previousNodeID
Review comment:
The words `previous` and `target` do not correspond... `Previous` corresponds to `current`, `source` corresponds to `target`.
##########
File path: thrift-datanode/src/main/thrift/datanode.thrift
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+include "rpc.thrift"
+namespace java org.apache.iotdb.service.rpc.thrift
+namespace py iotdb.thrift.rpc
+
+typedef i32 int
+typedef i64 long
+
+struct CreateSchemaRegionReq {
+ 1: required list<int> DataNodeID
+ 2: required int schemaRegionID
+}
+
+struct CreateDataRegionReq {
+ 1: required list<int> DataNodeID
+ 2: required int dataRegionID
+}
+
+struct CreateDataPartitionReq{
+ 1: required list<int> DataNodeID
Review comment:
same as above
##########
File path: thrift-datanode/src/main/thrift/datanode.thrift
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+include "rpc.thrift"
+namespace java org.apache.iotdb.service.rpc.thrift
+namespace py iotdb.thrift.rpc
+
+typedef i32 int
+typedef i64 long
+
+struct CreateSchemaRegionReq {
+ 1: required list<int> DataNodeID
+ 2: required int schemaRegionID
+}
+
+struct CreateDataRegionReq {
+ 1: required list<int> DataNodeID
+ 2: required int dataRegionID
+}
+
+struct CreateDataPartitionReq{
+ 1: required list<int> DataNodeID
+ 2: required int dataRegionID
+ 3: required long timeInterval
+}
+
+struct MigrateSchemaRegionReq{
+ 1: required int previousNodeID
+ 2: required int targetNodeID
+ 3: required int schemaRegionID
+}
+struct MigrateDataRegionReq{
+ 1: required int previousNodeID
Review comment:
better to use `xxxDataNodeID` rather than `xxxNodeID`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org