You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/04/24 16:17:31 UTC

[GitHub] [camel] gansheer opened a new pull request, #9921: doc: Add default camel metrics to micrometer component

gansheer opened a new pull request, #9921:
URL: https://github.com/apache/camel/pull/9921

   # Description
   
   Add the default Camel metrics on the micrometer component documentation. 
   
   # Target
   
   - [X] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [X] I checked that each commit in the pull request has a meaningful subject line and body.
   
   <!--  
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   -->
   
   - [X] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
   
   <!-- 
   You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
   
   You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] gansheer commented on pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #9921:
URL: https://github.com/apache/camel/pull/9921#issuecomment-1520569518

   > Hmm we should check what that message history metric really output
   
   I did not actually manage to see this one, if you have any idea what it does don't hesitate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus commented on pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9921:
URL: https://github.com/apache/camel/pull/9921#issuecomment-1520603045

   |camel.message.history| Timer.Sample | Sample of performance of each node in the route when message history is enabled


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9921:
URL: https://github.com/apache/camel/pull/9921#issuecomment-1520470626

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus commented on pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9921:
URL: https://github.com/apache/camel/pull/9921#issuecomment-1520545661

   Hmm we should check what that message history metric really output


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] gansheer commented on pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #9921:
URL: https://github.com/apache/camel/pull/9921#issuecomment-1520471387

   Some metrics might still be missing, if anyone see one missing please feel free to tell me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9921:
URL: https://github.com/apache/camel/pull/9921#issuecomment-1521506470

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 3 | 3 | 1 | 3 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9921:
URL: https://github.com/apache/camel/pull/9921#issuecomment-1520538113

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 2 | 2 | 0 | 2 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] gansheer commented on pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #9921:
URL: https://github.com/apache/camel/pull/9921#issuecomment-1521282133

   > |camel.message.history| Timer.Sample | Sample of performance of each node in the route when message history is enabled
   
   Thanks, I added it (with timer instead of Timer.Sample).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus commented on pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9921:
URL: https://github.com/apache/camel/pull/9921#issuecomment-1521324534

   |camel.exchange.event.notifier |gauge + summary | Metrics for message created, sent, completed, and failed events


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus merged pull request #9921: doc: Add default camel metrics to micrometer component

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9921:
URL: https://github.com/apache/camel/pull/9921


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org