You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/13 11:29:10 UTC

[GitHub] [flink] zentol opened a new pull request, #19458: [FLINK-27224][build] Drop 'flink.forkCountTestPackage' property

zentol opened a new pull request, #19458:
URL: https://github.com/apache/flink/pull/19458

   This property no longer provides any value because not only has it been identical to flink.forkCount for as long as I can remember, various other modules now contain tests that are likely even heavier than flink-tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on a diff in pull request #19458: [FLINK-27224][build] Drop 'flink.forkCountTestPackage' property

Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #19458:
URL: https://github.com/apache/flink/pull/19458#discussion_r849557454


##########
flink-tests/pom.xml:
##########
@@ -404,7 +404,7 @@ under the License.
 					</classpathDependencyExcludes>
 					<!-- We override the fork behaviour for those expensive tests to avoid process
 					kills due to container limits on travis -->
-					<forkCount>${flink.forkCountTestPackage}</forkCount>
+					<forkCount>${flink.forkCount}</forkCount>

Review Comment:
   Can't we get rid of these three lines entirely? We're not overriding anything anymore but do the same thing that's already done in the parent pom...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #19458: [FLINK-27224][build] Drop 'flink.forkCountTestPackage' property

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19458:
URL: https://github.com/apache/flink/pull/19458#issuecomment-1098375924

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19458: [FLINK-27224][build] Drop 'flink.forkCountTestPackage' property

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19458:
URL: https://github.com/apache/flink/pull/19458#issuecomment-1097945884

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8d2a4f2d6f89b079d1ad236a282d34fbe38e0fb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b8d2a4f2d6f89b079d1ad236a282d34fbe38e0fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8d2a4f2d6f89b079d1ad236a282d34fbe38e0fb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #19458: [FLINK-27224][build] Drop 'flink.forkCountTestPackage' property

Posted by GitBox <gi...@apache.org>.
zentol merged PR #19458:
URL: https://github.com/apache/flink/pull/19458


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #19458: [FLINK-27224][build] Drop 'flink.forkCountTestPackage' property

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19458:
URL: https://github.com/apache/flink/pull/19458#discussion_r849654347


##########
flink-tests/pom.xml:
##########
@@ -404,7 +404,7 @@ under the License.
 					</classpathDependencyExcludes>
 					<!-- We override the fork behaviour for those expensive tests to avoid process
 					kills due to container limits on travis -->
-					<forkCount>${flink.forkCountTestPackage}</forkCount>
+					<forkCount>${flink.forkCount}</forkCount>

Review Comment:
   yes, that's a good point



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org