Re: [PATCH] issue 2154 - svn blame on a directory over DAV does not return gracefully

[Justin Erenkrantz <ju...@erenkrantz.com>]

VK Sameer wrote:

> Checking for !derr first would let 'goto cleanup:' be retained in
> file_revs.c, but I don't know if that is a reasonable solution in all
> cases. version.c doesn't use the goto idiom, so it doesn't seem to need
> this fix. Comments?

I believe that checking for !derr first is reasonable as the flush is only
an optimization anyway.  So, if we got an error that we're going to
return, then it isn't critical for us to flush as its not likely we wrote
anything at that point.  -- justin


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] issue 2154 - svn blame on a directory over DAV does not return gracefully

[VK Sameer <sa...@collab.net>]

Attached is a patch based on Justin's comment.

'make davcheck' gave some errors in different test cases, merge_tests.py
once, but they didn't recur when run separately, leading me to think it
may have been due to my httpd performance configuration. 'make check'
passed.

Regards
Sameer