[GitHub] [carbondata] kunal642 commented on a change in pull request #4245: [CARBONDATA-4319] Fixed clean files not deleteting stale delete delta files after horizontal compaction

[GitBox <gi...@apache.org>]

kunal642 commented on a change in pull request #4245:
URL: https://github.com/apache/carbondata/pull/4245#discussion_r775411417



##########
File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java
##########
@@ -688,4 +689,124 @@ public static long getLatestDeleteDeltaTimestamp(String[] deleteDeltaFiles) {
     }
     return latestTimestamp;
   }
+
+
+  /**
+   * Handling of the clean up of old carbondata files, index files , delete delta,
+   * update status files.
+   *
+   * @param table       clean up will be handled on this table.
+   * @param isDryRun if true then max query execution timeout will not be considered.
+   */
+  public static long cleanUpDeltaFiles(CarbonTable table, boolean isDryRun) throws IOException {

Review comment:
       change isDryRun to forceDelete




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org