[GitHub] cstamas edited a comment on issue #197: SUREFIRE-1588 Patch (Java7)

[GitBox <gi...@apache.org>]

cstamas edited a comment on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435497122
 
 
   @Tibor17 I ran locally ITs of the current master (on affected Linux with b13 openjdk8), and I got totally different outcome: none of those ITs you mention failed, but instead I have:
   
   ```
   Results :
   
   Tests in error: 
     jarShouldUseFile(org.apache.maven.surefire.its.jiras.Surefire855AllowFailsafeUseArtifactFileIT): Exit code was non-zero: 1; command line and log = (..)
     warShouldUseClasses(org.apache.maven.surefire.its.jiras.Surefire855AllowFailsafeUseArtifactFileIT): Exit code was non-zero: 1; command line and log = (..)
    osgiBundleShouldUseFile(org.apache.maven.surefire.its.jiras.Surefire855AllowFailsafeUseArtifactFileIT): Exit code was non-zero: 1; command line and log = (..)
     testCharsetProvider(org.apache.maven.surefire.its.jiras.Surefire162CharsetProviderIT): Exit code was non-zero: 1; command line and log = (..)
     testSiblingAggregator(org.apache.maven.surefire.its.SiblingAggregatorIT): Exit code was non-zero: 1; command line and log = (..)
   
   Tests run: 780, Failures: 0, Errors: 5, Skipped: 138
   ```
   
   And the most interesting part: some ITs failed due SUREFIRE-1588! 
   
   For example, SUREFIRE-1588 causes org.apache.maven.surefire.its.SiblingAggregatorIT failure, produced traces like these:
   
   ```
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on project child2: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? -> [Help 1]
   org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on project child2: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ?
   ```
   
   Please note, all 2.x surefire plugin versions are affected of SUREFIRE-1588, hence it failed (unsure why IT uses 2.12.4 in the first place and not the built plugin).
   
   Surefire162CharsetProviderIT fails due this
   ```
   Caused by: org.apache.maven.project.DependencyResolutionException: Could not resolve dependencies for project org.apache.maven.surefire.its:surefire-162-charsetProvider:jar:1.0-SNAPSHOT: Could not find artifact jcharset:jcharset:jar:1.2.1 in central (https://repo.maven.apache.org/maven2/)
   ```
   
   And is right, there is no such thing.
   
   And finally the Surefire855 tests fails as they assert this
   
   ```
   Expected: a string containing "/target/jiras-surefire-855-jar-1.0.jar"
        but: was "../../../../../../../../.m2/repository-oss/org/apache/maven/surefire/surefire-booter/3.0.0-M1-SNAPSHOT/surefire-booter-3.0.0-M1-SNAPSHOT.jar ../../../../../../../../.m2/repository-oss/org/apache/maven/surefire/surefire-api/3.0.0-M1-SNAPSHOT/surefire-api-3.0.0-M1-SNAPSHOT.jar ../../../../../../../../.m2/repository-oss/org/apache/maven/surefire/surefire-logger-api/3.0.0-M1-SNAPSHOT/surefire-logger-api-3.0.0-M1-SNAPSHOT.jar ../test-classes/ ../jiras-surefire-855-jar-1.0.jar ../../../../../../../../.m2/repository-oss/junit/junit/4.11/junit-4.11.jar ../../../../../../../../.m2/repository-oss/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar ../../../../../../../../.m2/repository-oss/org/easytesting/fest-assert-core/2.0M9/fest-assert-core-2.0M9.jar ../../../../../../../../.m2/repository-oss/org/easytesting/fest-util/1.2.4/fest-util-1.2.4.jar ../../../../../../../../.m2/repository-oss/org/hamcrest/hamcrest-library/1.3/hamcrest-library-1.3.jar ../../../../../../../../.m2/repository-oss/org/apache/maven/surefire/surefire-junit4/3.0.0-M1-SNAPSHOT/surefire-junit4-3.0.0-M1-SNAPSHOT.jar ../../../../../../../../.m2/repository-oss/org/apache/maven/surefire/common-java5/3.0.0-M1-SNAPSHOT/common-java5-3.0.0-M1-SNAPSHOT.jar ../../../../../../../../.m2/repository-oss/org/apache/maven/surefire/common-junit3/3.0.0-M1-SNAPSHOT/common-junit3-3.0.0-M1-SNAPSHOT.jar ../../../../../../../../.m2/repository-oss/org/apache/maven/surefire/common-junit4/3.0.0-M1-SNAPSHOT/common-junit4-3.0.0-M1-SNAPSHOT.jar ../../../../../../../../.m2/repository-oss/org/apache/maven/shared/maven-shared-utils/3.1.0/maven-shared-utils-3.1.0.jar"
   ```
   So, it is there but as relative URI `../jiras-surefire-855-jar-1.0.jar`.
   
   So all in all, I have no clue what is happening on master. In the mean time, I started ITs of this PR (so 2.22.1+this patch w/ logger removed). Will report back how that goes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services