You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/06 18:17:26 UTC
[GitHub] betodealmeida commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration
betodealmeida commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration
URL: https://github.com/apache/incubator-superset/pull/4755#discussion_r179837129
##########
File path: superset/assets/javascripts/explore/stores/controls.jsx
##########
@@ -699,21 +699,21 @@ export const controls = {
freeForm: true,
label: t('Time Granularity'),
default: 'one day',
- choices: formatSelectOptions([
- 'all',
- '5 seconds',
- '30 seconds',
- '1 minute',
- '5 minutes',
- '1 hour',
- '6 hour',
- '1 day',
- '7 days',
- 'week',
- 'week_starting_sunday',
- 'week_ending_saturday',
- 'month',
- ]),
+ choices: [
+ [null, 'all'],
+ ['PT5S', '5 seconds'],
Review comment:
It does, it loads with the saved value as freeform:
<img width="262" alt="screen shot 2018-04-06 at 11 16 44 am" src="https://user-images.githubusercontent.com/1534870/38437359-0cd5cc42-398c-11e8-865b-32c646d21699.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services