You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/30 09:30:38 UTC

[GitHub] [kafka] chia7712 opened a new pull request #9355: MINOR: tweak the callback of committing offsets

chia7712 opened a new pull request #9355:
URL: https://github.com/apache/kafka/pull/9355


   The following changes are included.
   
   1. don't create unnecessary ```OffsetCommitCompletion``` if users don't define callback
   1. log the error of finding coordinator if user don't define callback
   1. add unit test of failing to commit offsets when using callback
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 closed pull request #9355: MINOR: tweak the callback of committing offsets

Posted by GitBox <gi...@apache.org>.

chia7712 closed pull request #9355:
URL: https://github.com/apache/kafka/pull/9355


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org