[GitHub] [spark] rithwik-db commented on a diff in pull request #42087: [SPARK-44264] Added Example to Deepspeed Distributor

["rithwik-db (via GitHub)" <gi...@apache.org>]

rithwik-db commented on code in PR #42087:
URL: https://github.com/apache/spark/pull/42087#discussion_r1274259415


##########
python/pyspark/ml/deepspeed/deepspeed_distributor.py:
##########
@@ -35,11 +35,11 @@ class DeepspeedTorchDistributor(TorchDistributor):
 
     def __init__(
         self,
-        num_gpus: int = 1,
+        numGpus: int = 1,

Review Comment:
   I think it would be best to stay as similar to the Deepspeed cli as possible; [Deepspeed](https://www.deepspeed.ai/getting-started/) uses `--num_gpus` so I think `numGpus` would be closer to that API than `ngpus`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org