[jira] [Commented] (ATLAS-3690) storm qualiftname of hbase is not right

["Madhan Neethiraj (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067702#comment-17067702 ] 

Madhan Neethiraj commented on ATLAS-3690:
-----------------------------------------

[~jackylau] - you are right. Storm hook has incorrect qualifiedName format for HBase table. This should be replaced with the following format used in HBase hook.

{code}
  class HBaseAtlasHook {
    ...
    public static final String HBASE_TABLE_QUALIFIED_NAME_FORMAT         = "%s:%s@%s";
  }
{code}

If you already have a patch to fix this issue, can you please attach to the JIA? Thanks!


> storm qualiftname of hbase is not right
> ---------------------------------------
>
>                 Key: ATLAS-3690
>                 URL: https://issues.apache.org/jira/browse/ATLAS-3690
>             Project: Atlas
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: jackylau
>            Priority: Major
>             Fix For: 2.1.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> hi all, when i read the code of storm hook, i found that 
> {code:java}
> // code placeholder
> public static String getHbaseTableQualifiedName(String metadataNamespace, String nameSpace, String tableName) {
>     return String.format("%s.%s@%s", nameSpace.toLowerCase(), tableName.toLowerCase(), metadataNamespace);
> }
> {code}
> I am not familiar with atlas, i think the qualified name is unique for search by JanusGraph.
> And the atlas  document of hbase table is used with separator ":"
> So I think it should be %s:%s@%s.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)