You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/07 12:42:30 UTC

[GitHub] [beam] bullet03 opened a new pull request, #23065: [Website] Update pre tag copy link styles

bullet03 opened a new pull request, #23065:
URL: https://github.com/apache/beam/pull/23065

   Resolves #23064
   - update pre tag copy link styles, change from float to position absolute 
   ------------------------
   before:
   ![before_copy](https://user-images.githubusercontent.com/61748758/188880794-b86c5167-371d-410a-accb-0740ef7ba176.gif)
   after:
   ![after_copy](https://user-images.githubusercontent.com/61748758/188880815-2439f01b-0abd-4258-9aa4-d962d4cafd30.gif)
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23065: [Website] Update copy icon styles

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23065:
URL: https://github.com/apache/beam/pull/23065#issuecomment-1314894260

   > @bullet03 I don't see it was approved, was it? CC: @pcoet
   
   ![1](https://user-images.githubusercontent.com/61748758/201855565-74a652b4-3e58-46eb-85fb-c01aa7125e0f.JPG)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AlyaBoiko commented on pull request #23065: [Website] Update copy icon styles

Posted by GitBox <gi...@apache.org>.
AlyaBoiko commented on PR #23065:
URL: https://github.com/apache/beam/pull/23065#issuecomment-1265440877

   Verified, works as expected. Reviewed and tested by QA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23065: [Website] Update copy icon styles

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23065:
URL: https://github.com/apache/beam/pull/23065#issuecomment-1313444008

   @aromanenko-dev, could you kindly help with merging? PR was tested and approved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #23065: [Website] Update copy icon styles

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #23065:
URL: https://github.com/apache/beam/pull/23065#issuecomment-1313747768

   @bullet03 I don't see it was approved, was it?
   CC: @pcoet 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23065: [Website] Update copy icon styles

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23065:
URL: https://github.com/apache/beam/pull/23065#issuecomment-1315161774

   > Ok, I missed that. LGTM
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23065: [Website] Update copy icon styles

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23065:
URL: https://github.com/apache/beam/pull/23065#issuecomment-1313442012

   There is a bug with copy icon moving with horizontal scroll. It it not a regress due to current PR, such behaviour was present before. Should be fixed in separate PR.
   ![bug_copy_icon](https://user-images.githubusercontent.com/61748758/201636913-e3e05cac-98ee-4dd8-89ff-3a57055ba774.gif)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23065: [Website] Update copy icon styles

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23065:
URL: https://github.com/apache/beam/pull/23065#issuecomment-1263928378

   @pcoetm could you, please, help with review of PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev merged pull request #23065: [Website] Update copy icon styles

Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #23065:
URL: https://github.com/apache/beam/pull/23065


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org