You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/06/15 21:40:00 UTC

[jira] [Work logged] (KNOX-2389) AliasBasedTokenStateService stops processing persisted journal entries if one is malformed

     [ https://issues.apache.org/jira/browse/KNOX-2389?focusedWorklogId=446137&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446137 ]

ASF GitHub Bot logged work on KNOX-2389:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jun/20 21:39
            Start Date: 15/Jun/20 21:39
    Worklog Time Spent: 10m 
      Work Description: pzampino opened a new pull request #346:
URL: https://github.com/apache/knox/pull/346


   …urnal entries if one is malformed
   
   ## What changes were proposed in this pull request?
   
   Added some defensive logic to prevent skipping processing valid token state journal entries due one or more invalid entries.
   
   ## How was this patch tested?
   
   _mvn -T1.5C -Ppackage,release clean install_,  augmented AliasBasedTokenStateServiceTest to include a specific test for this, and performed manual testing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 446137)
    Remaining Estimate: 0h
            Time Spent: 10m

> AliasBasedTokenStateService stops processing persisted journal entries if one is malformed
> ------------------------------------------------------------------------------------------
>
>                 Key: KNOX-2389
>                 URL: https://issues.apache.org/jira/browse/KNOX-2389
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 1.5.0
>            Reporter: Philip Zampino
>            Assignee: Philip Zampino
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the init methods of AliasBasedTokenStateService, while processing persisted TokenStateJournal entries, if one entry is malformed, then all subsequent entries are skipped. If the token ID is invalid, then the initialization of the service will fail altogether.
> This method should be more resilient, reporting malformed / invalid journal entries, but proceeding with the remaining entries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)