You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2022/10/22 17:45:54 UTC
[commons-csv] branch master updated: Test javadoc updates and typos
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-csv.git
The following commit(s) were added to refs/heads/master by this push:
new 4ddeddc2 Test javadoc updates and typos
4ddeddc2 is described below
commit 4ddeddc2a1a7b9f544fffc2badf76f718eb4cd4f
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Oct 22 18:45:45 2022 +0100
Test javadoc updates and typos
---
.../apache/commons/csv/CSVDuplicateHeaderTest.java | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/test/java/org/apache/commons/csv/CSVDuplicateHeaderTest.java b/src/test/java/org/apache/commons/csv/CSVDuplicateHeaderTest.java
index aba2a607..2c5f520b 100644
--- a/src/test/java/org/apache/commons/csv/CSVDuplicateHeaderTest.java
+++ b/src/test/java/org/apache/commons/csv/CSVDuplicateHeaderTest.java
@@ -27,13 +27,14 @@ import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
/**
- * Tests {@link CSVFormat}.
+ * Tests parsing of duplicate column names in a CSV header.
+ * The test verifies that headers are consistently handled by CSVFormat and CSVParser.
*/
public class CSVDuplicateHeaderTest {
/**
* Return test cases for duplicate header data. Uses the order:
* <pre>
- * DuplicateHeaderMode duolicateHeaderMode
+ * DuplicateHeaderMode duplicateHeaderMode
* boolean allowMissingColumnNames
* String[] headers
* boolean valid
@@ -98,24 +99,24 @@ public class CSVDuplicateHeaderTest {
/**
* Test duplicate headers with the CSVFormat.
*
- * @param duolicateHeaderMode the duolicate header mode
+ * @param duplicateHeaderMode the duplicate header mode
* @param allowMissingColumnNames the allow missing column names flag
* @param headers the headers
* @param valid true if the settings are expected to be valid
*/
@ParameterizedTest
@MethodSource(value = {"duplicateHeaderData"})
- public void testCSVFormat(DuplicateHeaderMode duolicateHeaderMode,
+ public void testCSVFormat(DuplicateHeaderMode duplicateHeaderMode,
boolean allowMissingColumnNames,
String[] headers,
boolean valid) {
CSVFormat.Builder builder = CSVFormat.DEFAULT.builder()
- .setDuplicateHeaderMode(duolicateHeaderMode)
+ .setDuplicateHeaderMode(duplicateHeaderMode)
.setAllowMissingColumnNames(allowMissingColumnNames)
.setHeader(headers);
if (valid) {
CSVFormat format = builder.build();
- Assertions.assertEquals(duolicateHeaderMode, format.getDuplicateHeaderMode(), "DuplicateHeaderMode");
+ Assertions.assertEquals(duplicateHeaderMode, format.getDuplicateHeaderMode(), "DuplicateHeaderMode");
Assertions.assertEquals(allowMissingColumnNames, format.getAllowMissingColumnNames(), "AllowMissingColumnNames");
Assertions.assertArrayEquals(headers, format.getHeader(), "Header");
} else {
@@ -126,7 +127,7 @@ public class CSVDuplicateHeaderTest {
/**
* Test duplicate headers with the CSVParser.
*
- * @param duolicateHeaderMode the duolicate header mode
+ * @param duplicateHeaderMode the duplicate header mode
* @param allowMissingColumnNames the allow missing column names flag
* @param headers the headers (joined with the CSVFormat delimiter to create a string input)
* @param valid true if the settings are expected to be valid
@@ -134,12 +135,12 @@ public class CSVDuplicateHeaderTest {
*/
@ParameterizedTest
@MethodSource(value = {"duplicateHeaderData"})
- public void testCSVParser(DuplicateHeaderMode duolicateHeaderMode,
+ public void testCSVParser(DuplicateHeaderMode duplicateHeaderMode,
boolean allowMissingColumnNames,
String[] headers,
boolean valid) throws IOException {
CSVFormat format = CSVFormat.DEFAULT.builder()
- .setDuplicateHeaderMode(duolicateHeaderMode)
+ .setDuplicateHeaderMode(duplicateHeaderMode)
.setAllowMissingColumnNames(allowMissingColumnNames)
.setHeader()
.build();