You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/10 21:20:26 UTC

[GitHub] [geode] pivotal-eshu opened a new pull request #5837: GEODE-8780: Increase the default number of function execution threads.

pivotal-eshu opened a new pull request #5837:
URL: https://github.com/apache/geode/pull/5837


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] pivotal-eshu merged pull request #5837: GEODE-8780: Increase the default number of function execution threads.

Posted by GitBox <gi...@apache.org>.
pivotal-eshu merged pull request #5837:
URL: https://github.com/apache/geode/pull/5837


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] pivotal-eshu commented on pull request #5837: GEODE-8780: Increase the default number of function execution threads.

Posted by GitBox <gi...@apache.org>.
pivotal-eshu commented on pull request #5837:
URL: https://github.com/apache/geode/pull/5837#issuecomment-742864483


   > Might it be worth adding a test case to confirm that when the `DistributionManager.MAX_FE_THREADS` property is set, that value is used? Also, it looks like that property is documented in `properties.html`, so that file should probably be updated to reflect the new default value. Is there a reason that there's no other documentation for this property?
   
   Change the default value in the properties.html. I am not sure why there is no other documentation for this property. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org