svn commit: r488778 - /incubator/solr/trunk/src/webapp/src/org/apache/solr/servlet/SolrServlet.java

[kl...@apache.org]

Author: klaas
Date: Tue Dec 19 11:31:26 2006
New Revision: 488778

URL: http://svn.apache.org/viewvc?view=rev&rev=488778
Log:
Moved creation of reqeust and response out of the try/finally block.  I don't see any way for 
them to throw an exception, and it is bad form to reference a variable created in the try in 
the finally block (fortifysoftware issue)

 --This line, and those below, will be ignored--

M    src/webapp/src/org/apache/solr/servlet/SolrServlet.java

Modified:
    incubator/solr/trunk/src/webapp/src/org/apache/solr/servlet/SolrServlet.java

Modified: incubator/solr/trunk/src/webapp/src/org/apache/solr/servlet/SolrServlet.java
URL: http://svn.apache.org/viewvc/incubator/solr/trunk/src/webapp/src/org/apache/solr/servlet/SolrServlet.java?view=diff&rev=488778&r1=488777&r2=488778
==============================================================================
--- incubator/solr/trunk/src/webapp/src/org/apache/solr/servlet/SolrServlet.java (original)
+++ incubator/solr/trunk/src/webapp/src/org/apache/solr/servlet/SolrServlet.java Tue Dec 19 11:31:26 2006
@@ -84,11 +84,9 @@
   }
 
   public void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
-    SolrServletRequest solrReq =null;
-    SolrQueryResponse solrRsp =null;
+    SolrServletRequest solrReq = new SolrServletRequest(core, request);;
+    SolrQueryResponse solrRsp = new SolrQueryResponse();
     try {
-      solrRsp = new SolrQueryResponse();
-      solrReq = new SolrServletRequest(core, request);
       core.execute(solrReq, solrRsp);
       if (solrRsp.getException() == null) {
         QueryResponseWriter responseWriter = core.getQueryResponseWriter(solrReq);