You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Jeff Hammerbacher (JIRA)" <ji...@apache.org> on 2009/11/19 11:17:40 UTC

[jira] Created: (AVRO-215) Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py

Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py
----------------------------------------------------------------------------------------

                 Key: AVRO-215
                 URL: https://issues.apache.org/jira/browse/AVRO-215
             Project: Avro
          Issue Type: Improvement
          Components: python
            Reporter: Jeff Hammerbacher


As pointed out by Doug on the mailing list, the point of the "seen" parameter is to "contain the set of schemas that are on the stack.  Schemas can be circular, so this is required to prevent infinite loops."


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-215) Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py and explore use of decorators for memoization

Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Hammerbacher updated AVRO-215:
-----------------------------------

    Summary: Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py and explore use of decorators for memoization  (was: Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py)

> Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py and explore use of decorators for memoization
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-215
>                 URL: https://issues.apache.org/jira/browse/AVRO-215
>             Project: Avro
>          Issue Type: Improvement
>          Components: python
>            Reporter: Jeff Hammerbacher
>
> As pointed out by Doug on the mailing list, the point of the "seen" parameter is to "contain the set of schemas that are on the stack.  Schemas can be circular, so this is required to prevent infinite loops."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (AVRO-215) Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py and explore use of decorators for memoization

Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Hammerbacher reassigned AVRO-215:
--------------------------------------

    Assignee: Jeff Hammerbacher

> Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py and explore use of decorators for memoization
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-215
>                 URL: https://issues.apache.org/jira/browse/AVRO-215
>             Project: Avro
>          Issue Type: Improvement
>          Components: python
>            Reporter: Jeff Hammerbacher
>            Assignee: Jeff Hammerbacher
>
> As pointed out by Doug on the mailing list, the point of the "seen" parameter is to "contain the set of schemas that are on the stack.  Schemas can be circular, so this is required to prevent infinite loops."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AVRO-215) Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py and explore use of decorators for memoization

Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Hammerbacher resolved AVRO-215.
------------------------------------

    Resolution: Won't Fix

Moot point with AVRO-219

> Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py and explore use of decorators for memoization
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-215
>                 URL: https://issues.apache.org/jira/browse/AVRO-215
>             Project: Avro
>          Issue Type: Improvement
>          Components: python
>            Reporter: Jeff Hammerbacher
>            Assignee: Jeff Hammerbacher
>
> As pointed out by Doug on the mailing list, the point of the "seen" parameter is to "contain the set of schemas that are on the stack.  Schemas can be circular, so this is required to prevent infinite loops."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-215) Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py

Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779919#action_12779919 ] 

Jeff Hammerbacher commented on AVRO-215:
----------------------------------------

Note also that memoization is a common use of decorators, and decorators are available in Python 2.4+. If we're comfortable requiring Python 2.4 (seems reasonable to me), we can explore the use decorators here.

> Add docstring indicating utility of "seen" parameter to __hash__ and __eq__ in schema.py
> ----------------------------------------------------------------------------------------
>
>                 Key: AVRO-215
>                 URL: https://issues.apache.org/jira/browse/AVRO-215
>             Project: Avro
>          Issue Type: Improvement
>          Components: python
>            Reporter: Jeff Hammerbacher
>
> As pointed out by Doug on the mailing list, the point of the "seen" parameter is to "contain the set of schemas that are on the stack.  Schemas can be circular, so this is required to prevent infinite loops."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.