You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/01/04 11:29:19 UTC

Review Request 16631: Added average system load and cpu count in master and slave stats end-points.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16631/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, Ross Allen, and Vinod Kone.


Bugs: MESOS-581
    https://issues.apache.org/jira/browse/MESOS-581


Repository: mesos-git


Description
-------

This patch expose average system load (usual uptime(1) style;1, 5 and
15 minutes averages) along with local cpu count. The fields are named
system_cpus, system_load_XXmin mostly to disambiguate from the
cpus_total, cpus_used, ... aggregates in the master/stats.json.
I am open to change the new field naming.


Diffs
-----

  src/master/http.cpp d7cd89f 
  src/slave/http.cpp 1358810 

Diff: https://reviews.apache.org/r/16631/diff/


Testing
-------

make check and functional testing of /stats.json endpoints.


Thanks,

Niklas Nielsen

Re: Review Request 16631: Added average system load and cpu count in master and slave stats end-points.

Posted by Niklas Nielsen <ni...@qni.dk>.


> On Jan. 21, 2014, 11:10 a.m., Vinod Kone wrote:
> > Ship It!

BenM suggested that we'd move this to common HTTP handler for system metrics in libprocess e.g. /system. What are your thoughts on that approach? In that case, I'd close this RR and start a new one.


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16631/#review32398
-----------------------------------------------------------


On Jan. 4, 2014, 2:29 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16631/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2014, 2:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ross Allen, and Vinod Kone.
> 
> 
> Bugs: MESOS-581
>     https://issues.apache.org/jira/browse/MESOS-581
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch expose average system load (usual uptime(1) style;1, 5 and
> 15 minutes averages) along with local cpu count. The fields are named
> system_cpus, system_load_XXmin mostly to disambiguate from the
> cpus_total, cpus_used, ... aggregates in the master/stats.json.
> I am open to change the new field naming.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp d7cd89f 
>   src/slave/http.cpp 1358810 
> 
> Diff: https://reviews.apache.org/r/16631/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing of /stats.json endpoints.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 16631: Added average system load and cpu count in master and slave stats end-points.

Posted by Vinod Kone <vi...@gmail.com>.


> On Jan. 21, 2014, 7:10 p.m., Vinod Kone wrote:
> > Ship It!
> 
> Niklas Nielsen wrote:
>     BenM suggested that we'd move this to common HTTP handler for system metrics in libprocess e.g. /system. What are your thoughts on that approach? In that case, I'd close this RR and start a new one.

sgtm.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16631/#review32398
-----------------------------------------------------------


On Jan. 4, 2014, 10:29 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16631/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2014, 10:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ross Allen, and Vinod Kone.
> 
> 
> Bugs: MESOS-581
>     https://issues.apache.org/jira/browse/MESOS-581
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch expose average system load (usual uptime(1) style;1, 5 and
> 15 minutes averages) along with local cpu count. The fields are named
> system_cpus, system_load_XXmin mostly to disambiguate from the
> cpus_total, cpus_used, ... aggregates in the master/stats.json.
> I am open to change the new field naming.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp d7cd89f 
>   src/slave/http.cpp 1358810 
> 
> Diff: https://reviews.apache.org/r/16631/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing of /stats.json endpoints.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 16631: Added average system load and cpu count in master and slave stats end-points.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16631/#review32398
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Jan. 4, 2014, 10:29 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16631/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2014, 10:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ross Allen, and Vinod Kone.
> 
> 
> Bugs: MESOS-581
>     https://issues.apache.org/jira/browse/MESOS-581
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch expose average system load (usual uptime(1) style;1, 5 and
> 15 minutes averages) along with local cpu count. The fields are named
> system_cpus, system_load_XXmin mostly to disambiguate from the
> cpus_total, cpus_used, ... aggregates in the master/stats.json.
> I am open to change the new field naming.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp d7cd89f 
>   src/slave/http.cpp 1358810 
> 
> Diff: https://reviews.apache.org/r/16631/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing of /stats.json endpoints.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>