[jira] Commented: (OFBIZ-552) Integration Shark 1.1_2 into OfBiz

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463919 ] 

Jacques Le Roux commented on OFBIZ-552:
---------------------------------------

Sergey,

Wow, this is an huge patch !

Please consider this 1st comments as only admin/formattng stuffes and not technical ones

. Please don' t use tabs in your files and patches. BTW you may have a look at http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

. If you want this patch being commited to OFBiz you will have to check the ASF grant when attaching your patch. In the same spirit please don't let copyright info in your files/patches, like
+@Modified by Sergey Shutov. Tecomgroup company.
+@E-mail : sshutov@tecomgroup.ru

. I think that comments with your name like <!-- Modified field "eventAuditId" with type "id-ne"  by Sergey Shutov --> are ok BTW. But they are not necessary because SVN take care of that (history). So for us (commiters) they only add more lines to go through.... So please delete them.

Thanks for your  work !



> Integration Shark 1.1_2 into OfBiz
> ----------------------------------
>
>                 Key: OFBIZ-552
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-552
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Sergey Shutov
>         Attachments: shark.diff
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira