You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "vladnovoren (via GitHub)" <gi...@apache.org> on 2025/01/14 16:35:51 UTC
[PR] IGNITE-24096 Remove GridDhtPartitionSupplyMessageV2#AVAILABLE_SINCE [ignite]
vladnovoren opened a new pull request, #11811:
URL: https://github.com/apache/ignite/pull/11811
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24096 Remove GridDhtPartitionSupplyMessageV2#AVAILABLE_SINCE [ignite]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on PR #11811:
URL: https://github.com/apache/ignite/pull/11811#issuecomment-2606540591
Let's rename `GridDhtPartitionSupplyMessageV2` to `GridDhtPartitionSupplyErrorMessage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24096 Remove GridDhtPartitionSupplyMessageV2#AVAILABLE_SINCE [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11811:
URL: https://github.com/apache/ignite/pull/11811#issuecomment-2606526086
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11811) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11811&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11811&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=11811&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11811&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11811&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11811)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24096 Remove GridDhtPartitionSupplyMessageV2#AVAILABLE_SINCE [ignite]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on code in PR #11811:
URL: https://github.com/apache/ignite/pull/11811#discussion_r1916246831
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionSupplier.java:
##########
@@ -444,8 +444,7 @@ else if (iter.isPartitionMissing(p)) {
if (grp.shared().kernalContext().isStopping())
return;
- // Sending supply messages with error requires new protocol.
- boolean sendErrMsg = demanderNode.version().compareTo(GridDhtPartitionSupplyMessageV2.AVAILABLE_SINCE) >= 0;
+ boolean sendErrMsg = true;
Review Comment:
Let's rewrite it more clear:
```
boolean sendErrMsg = !(t instanceof IgniteSpiException);
if (sendErrMsg) {
U.error(log, "Failed to continue supplying ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ']', t);
}
else if (log.isDebugEnabled())
log.debug("Failed to send message to node (current node is stopping?) ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ", msg=" + t.getMessage() + ']');
try {
if (sctx != null)
clearContext(sctx, log);
}
catch (Throwable t1) {
U.error(log, "Failed to cleanup supplying context ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ']', t1);
}
if (!sendErrMsg)
return;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24096 Remove GridDhtPartitionSupplyMessageV2#AVAILABLE_SINCE [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11811:
URL: https://github.com/apache/ignite/pull/11811#issuecomment-2606602874
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11811) **Quality Gate failed**
Failed conditions
 [31.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11811&metric=new_duplicated_lines_density&view=list) (required ≤ 5%)
 [4 New Code Smells](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11811) (required ≤ 1)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11811)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24096 Remove GridDhtPartitionSupplyMessageV2#AVAILABLE_SINCE [ignite]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov merged PR #11811:
URL: https://github.com/apache/ignite/pull/11811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24096 Remove GridDhtPartitionSupplyMessageV2#AVAILABLE_SINCE [ignite]
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on code in PR #11811:
URL: https://github.com/apache/ignite/pull/11811#discussion_r1916246831
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionSupplier.java:
##########
@@ -444,8 +444,7 @@ else if (iter.isPartitionMissing(p)) {
if (grp.shared().kernalContext().isStopping())
return;
- // Sending supply messages with error requires new protocol.
- boolean sendErrMsg = demanderNode.version().compareTo(GridDhtPartitionSupplyMessageV2.AVAILABLE_SINCE) >= 0;
+ boolean sendErrMsg = true;
Review Comment:
Let's rewrite it more clear:
```
boolean skipErrMsg = t instanceof IgniteSpiException;
if (skipErrMsg) {
if (log.isDebugEnabled())
log.debug("Failed to send message to node (current node is stopping?) ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ", msg=" + t.getMessage() + ']');
}
else
U.error(log, "Failed to continue supplying ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ']', t);
try {
if (sctx != null)
clearContext(sctx, log);
}
catch (Throwable t1) {
U.error(log, "Failed to cleanup supplying context ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ']', t1);
}
if (skipErrMsg)
return;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org