You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2017/02/28 00:34:35 UTC
[GitHub] cordova-lib pull request #523: CB-11346
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/523
CB-11346
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
All, none, ...
### What does this PR do?
Removes multiple checks for 'known' platforms
### What testing has been done on this change?
tested by adding a new platform that was not in the known-good list
specs to follow ...
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-lib CB-11346
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #523
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #523: CB-11346 Remove known platforms checks
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #523: CB-11346 Remove known platforms checks
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/523
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=h1) Report
> Merging [#523](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/b0402b9e51bf2d97488fedd39d13348b29f81c3c?src=pr&el=desc) will **decrease** coverage by `-0.01%`.
> The diff coverage is `95.45%`.
```diff
@@ Coverage Diff @@
## master #523 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.01%
=========================================
Files 68 68
Lines 5504 5503 -1
Branches 1090 1088 -2
=========================================
- Hits 4508 4507 -1
Misses 996 996
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=) | `93.75% <�> (-0.05%)` | :x: |
| [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `97.28% <100%> (�)` | :white_check_mark: |
| [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `78.25% <100%> (�)` | :white_check_mark: |
| [cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=) | `96.66% <92.85%> (+0.11%)` | :white_check_mark: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr&el=footer). Last update [b0402b9...21c4565](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...21c4565b0760d4103ad707832fd15ab8b837ab1e?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #523: CB-11346 Remove known platforms checks
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/523
Let there be tests!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org