You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/11 09:45:37 UTC

[GitHub] [dolphinscheduler] ChPi opened a new issue, #12870: [Bug] [server] task retry throws NullPointerException

ChPi opened a new issue, #12870:
URL: https://github.com/apache/dolphinscheduler/issues/12870

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
    task retry throws NullPointerException。
   the `taskInstanceId` type  of class `TaskStateEvent` is int, but set null when retry a task, should it be Integer?
   
   ### What you expected to happen
   
   retry success
   
   ### How to reproduce
   
   create a http retry task, then run
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   3.1.x
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ChPi commented on issue #12870: [Bug] [server] task retry throws NullPointerException

Posted by GitBox <gi...@apache.org>.
ChPi commented on issue #12870:
URL: https://github.com/apache/dolphinscheduler/issues/12870#issuecomment-1314898972

   > If the task instance Id is null, means the task instance has not been submit, it shouldn't retry.
   
   retry task will `cloneRetryTaskInstance` that do not set id.
   will retry task generate a new id and insert into table  `t_ds_task_instance` rather than updating the old record? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12870: [Bug] [server] task retry throws NullPointerException

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12870:
URL: https://github.com/apache/dolphinscheduler/issues/12870#issuecomment-1311467959

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] zhuangchong closed issue #12870: [Bug] [server] task retry throws NullPointerException

Posted by GitBox <gi...@apache.org>.
zhuangchong closed issue #12870: [Bug] [server] task retry throws NullPointerException
URL: https://github.com/apache/dolphinscheduler/issues/12870


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] hstdream commented on issue #12870: [Bug] [server] task retry throws NullPointerException

Posted by GitBox <gi...@apache.org>.
hstdream commented on issue #12870:
URL: https://github.com/apache/dolphinscheduler/issues/12870#issuecomment-1311550072

   Please provide detailed error log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ruanwenjun commented on issue #12870: [Bug] [server] task retry throws NullPointerException

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #12870:
URL: https://github.com/apache/dolphinscheduler/issues/12870#issuecomment-1314766010

   If the task instance Id is null, means the task instance has not been submit, it shouldn't retry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ChPi commented on issue #12870: [Bug] [server] task retry throws NullPointerException

Posted by GitBox <gi...@apache.org>.
ChPi commented on issue #12870:
URL: https://github.com/apache/dolphinscheduler/issues/12870#issuecomment-1312925659

   > Please provide detailed error log.
   
   ```
   [INFO] 2022-11-11 09:49:41.677 +0000 org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread:[344] - [TaskInstance-null]The task instance can
    retry, will retry this task instance
   [ERROR] 2022-11-11 09:49:41.678 +0000 org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread:[353] - Check task retry error, taskInstanceKey
   : TaskInstanceKey(processInstanceId=2, taskCode=7517199067616, taskVersion=2)
   java.lang.NullPointerException: null
           at org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread.addTaskRetryEvent(StateWheelExecuteThread.java:422)
           at org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread.checkTask4Retry(StateWheelExecuteThread.java:349)
           at org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread.run(StateWheelExecuteThread.java:105)
   [INFO] 2022-11-11 09:49:46.680 +0000 org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread:[344] - [TaskInstance-null]The task instance can
    retry, will retry this task instance
   [ERROR] 2022-11-11 09:49:46.681 +0000 org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread:[353] - Check task retry error, taskInstanceKey
   : TaskInstanceKey(processInstanceId=2, taskCode=7517199067616, taskVersion=2)
   java.lang.NullPointerException: null
           at org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread.addTaskRetryEvent(StateWheelExecuteThread.java:422)
           at org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread.checkTask4Retry(StateWheelExecuteThread.java:349)
           at org.apache.dolphinscheduler.server.master.runner.StateWheelExecuteThread.run(StateWheelExecuteThread.java:105)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ruanwenjun commented on issue #12870: [Bug] [server] task retry throws NullPointerException

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #12870:
URL: https://github.com/apache/dolphinscheduler/issues/12870#issuecomment-1315290332

   > > If the task instance Id is null, means the task instance has not been submit, it shouldn't retry.
   > 
   > retry task will `cloneRetryTaskInstance` that do not set id. will retry task generate a new id and insert into table `t_ds_task_instance` rather than updating the old record?
   
   Yes, it will insert a new task instance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org