You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jorge Schrauwen <jo...@gmail.com> on 2009/06/19 18:30:06 UTC
Re: Please Review! Path for os/win32/os.h - new reports Win64 when
build for 64-bit
Sorry to dig up this old thread again but some users of my unofficial binary
have been complaining that it still says Win32.
So any chances somebody could look at this again. It's a rather trivial
change I think.
~Jorge
On Wed, Jul 26, 2006 at 11:00 PM, Jorge Schrauwen <jorge.schrauwen@gmail.com
> wrote:
> I just tried lots of diferent comment styles like #, ', ... till i found
> one that worked. never though there would be more that one... makes sence
> though, especially for larger blocks of comment.
>
> So here is an updated diff file.
>
> On 7/26/06, Ruediger Pluem <rp...@apache.org> wrote:
>>
>>
>>
>> On 07/26/2006 10:10 PM, Jorge Schrauwen wrote:
>> > Ok this is my first path so please bare with me and review.
>> >
>> > Since I'm rather new to C I did a lot of research and testing on this.
>> > More information regarding the changes:
>> > http://msdn.microsoft.com/msdnmag/issues/06/05/x64/default.aspx#S4
>> >
>> > ----------- os\win32\os.h -----------
>> >
>> > --- os.h.orig 2006-04-22 03:53:06.000000000 +0200
>> > +++ os.h 2006-07-26 21:22:24.000516000 +0200
>> > @@ -38,7 +38,11 @@
>> > #include <io.h>
>> > #include <fcntl.h>
>> >
>> > +//Checking the architecture we are compiling for (Itanium 64-bit, x64
>> > (AMD64/EM64T) or x86)
>>
>> I cannot comment on the subject itself as I am not a windows man, but only
>> on
>> the style: Please do not use C++ style comments like //. Please use always
>> /* */.
>> Regarding style the following page is very helpful:
>>
>> http://httpd.apache.org/dev/styleguide.html
>>
>> Regards
>>
>> Rüdiger
>>
>>
>
>
> --
> ~Jorge
Re: Please Review! Path for os/win32/os.h - new reports Win64 when
build for 64-bit
Posted by Jorge Schrauwen <jo...@gmail.com>.
I thought I did but couldn't find it.
I've create a new bug report:
https://issues.apache.org/bugzilla/show_bug.cgi?id=47418
~Jorge
On Wed, Jun 24, 2009 at 9:40 PM, Jorge Schrauwen
<jo...@gmail.com>wrote:
> I can't remember,
>
> I'll open one tomorrow when I have access to my updated patch.
>
> ~Jorge
>
>
>
> On Wed, Jun 24, 2009 at 7:55 PM, Mario Brandt<jb...@gmail.com> wrote:
> > Hi Jorge,
> > did you also open a bug in bugzilla?
> >
> > Mario
> >
> > On Fri, Jun 19, 2009 at 6:30 PM, Jorge
> > Schrauwen<jo...@gmail.com> wrote:
> >> Sorry to dig up this old thread again but some users of my unofficial
> binary
> >> have been complaining that it still says Win32.
> >>
> >> So any chances somebody could look at this again. It's a rather trivial
> >> change I think.
> >>
> >> ~Jorge
> >
>