[hive] branch master updated: HIVE-23077: Remove Calls to printStackTrace in Module hive-jdbc (David Mollitor reviewed by Naveen Gangam)

[dm...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dmollitor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 6275513  HIVE-23077: Remove Calls to printStackTrace in Module hive-jdbc (David Mollitor reviewed by Naveen Gangam)
6275513 is described below

commit 62755130eb008a0b09397f78d4fe947819b18273
Author: David Mollitor <dm...@apache.org>
AuthorDate: Mon Mar 30 09:24:33 2020 -0400

    HIVE-23077: Remove Calls to printStackTrace in Module hive-jdbc (David Mollitor reviewed by Naveen Gangam)
---
 jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java | 3 +--
 jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java        | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java b/jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java
index dfaa40f..350648f 100644
--- a/jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java
+++ b/jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java
@@ -419,8 +419,7 @@ public abstract class HiveBaseResultSet implements ResultSet {
       wasNull = evaluated == null;
       return evaluated;
     } catch (Exception e) {
-      e.printStackTrace();
-      throw new SQLException("Unrecognized column type:" + columnType, e);
+      throw new SQLException("Unrecognized column type: " + columnType, e);
     }
   }
 
diff --git a/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java b/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java
index 102683e..faa4d17 100644
--- a/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java
+++ b/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java
@@ -43,8 +43,7 @@ public class HiveDriver implements Driver {
     try {
       java.sql.DriverManager.registerDriver(new HiveDriver());
     } catch (SQLException e) {
-      // TODO Auto-generated catch block
-      e.printStackTrace();
+      throw new RuntimeException("Failed to register driver", e);
     }
   }