[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #773: [#772] fix(kerberos): cache proxy user ugi to avoid memory leak

["xianjingfeng (via GitHub)" <gi...@apache.org>]

xianjingfeng commented on code in PR #773:
URL: https://github.com/apache/incubator-uniffle/pull/773#discussion_r1150096502


##########
common/src/main/java/org/apache/uniffle/common/security/HadoopSecurityContext.java:
##########
@@ -38,6 +40,7 @@ public class HadoopSecurityContext implements SecurityContext {
 
   private UserGroupInformation loginUgi;
   private ScheduledExecutorService refreshScheduledExecutor;
+  private Map<String, UserGroupInformation> proxyUserUgiPool;

Review Comment:
   if use LRU, the memory leak problem still exists. By the way, should we use JavaUtils here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org