You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Matt Brictson (JIRA)" <ji...@apache.org> on 2011/03/11 22:31:59 UTC

[jira] Created: (WICKET-3526) CompressedResourceReference is unimplemented in Wicket 1.5

CompressedResourceReference is unimplemented in Wicket 1.5
----------------------------------------------------------

                 Key: WICKET-3526
                 URL: https://issues.apache.org/jira/browse/WICKET-3526
             Project: Wicket
          Issue Type: Bug
          Components: wicket-core
    Affects Versions: 1.5-RC2
            Reporter: Matt Brictson


CompressedResourceReference in trunk is basically empty and has the comment "TODO NG". A quick search through the source leads me to believe that IResourceSettings#getDisableGZipCompression() is also unused.

In other words, gzipping of resources is not implemented in Wicket 1.5, whereas it was working fine in Wicket 1.4.x.

Part of me thinks that maybe this feature should be dropped, as compression makes more sense to handle at the servlet container or web server layer (e.g. mod_deflate). Thoughts?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-3526) CompressedResourceReference is unimplemented in Wicket 1.5

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl resolved WICKET-3526.
--------------------------------

    Resolution: Fixed
      Assignee: Peter Ertl

> CompressedResourceReference is unimplemented in Wicket 1.5
> ----------------------------------------------------------
>
>                 Key: WICKET-3526
>                 URL: https://issues.apache.org/jira/browse/WICKET-3526
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC2
>            Reporter: Matt Brictson
>            Assignee: Peter Ertl
>
> CompressedResourceReference in trunk is basically empty and has the comment "TODO NG". A quick search through the source leads me to believe that IResourceSettings#getDisableGZipCompression() is also unused.
> In other words, gzipping of resources is not implemented in Wicket 1.5, whereas it was working fine in Wicket 1.4.x.
> Part of me thinks that maybe this feature should be dropped, as compression makes more sense to handle at the servlet container or web server layer (e.g. mod_deflate). Thoughts?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-3526) CompressedResourceReference is unimplemented in Wicket 1.5

Posted by "Chris Colman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105870#comment-13105870 ] 

Chris Colman commented on WICKET-3526:
--------------------------------------

In the migration page CompressedResourceReference is still listed as having a peer in the 1.5 release in the table "List of renamed classes and methods". It's entry should be (missing) or (removed) as it is actually not present in release 1.5.

> CompressedResourceReference is unimplemented in Wicket 1.5
> ----------------------------------------------------------
>
>                 Key: WICKET-3526
>                 URL: https://issues.apache.org/jira/browse/WICKET-3526
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC2
>            Reporter: Matt Brictson
>            Assignee: Peter Ertl
>
> CompressedResourceReference in trunk is basically empty and has the comment "TODO NG". A quick search through the source leads me to believe that IResourceSettings#getDisableGZipCompression() is also unused.
> In other words, gzipping of resources is not implemented in Wicket 1.5, whereas it was working fine in Wicket 1.4.x.
> Part of me thinks that maybe this feature should be dropped, as compression makes more sense to handle at the servlet container or web server layer (e.g. mod_deflate). Thoughts?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-3526) CompressedResourceReference is unimplemented in Wicket 1.5

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019590#comment-13019590 ] 

Peter Ertl commented on WICKET-3526:
------------------------------------

Dropped it since practically all modern servers can do it...

> CompressedResourceReference is unimplemented in Wicket 1.5
> ----------------------------------------------------------
>
>                 Key: WICKET-3526
>                 URL: https://issues.apache.org/jira/browse/WICKET-3526
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC2
>            Reporter: Matt Brictson
>
> CompressedResourceReference in trunk is basically empty and has the comment "TODO NG". A quick search through the source leads me to believe that IResourceSettings#getDisableGZipCompression() is also unused.
> In other words, gzipping of resources is not implemented in Wicket 1.5, whereas it was working fine in Wicket 1.4.x.
> Part of me thinks that maybe this feature should be dropped, as compression makes more sense to handle at the servlet container or web server layer (e.g. mod_deflate). Thoughts?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira