[GitHub] [ozone] duongnguyen0 commented on a diff in pull request #3594: HDDS-7009. Avoid calling getBucket in object APIs

[GitBox <gi...@apache.org>]

duongnguyen0 commented on code in PR #3594:
URL: https://github.com/apache/ozone/pull/3594#discussion_r924703597


##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestPermissionCheck.java:
##########
@@ -266,9 +274,10 @@ public void testGetKey() throws IOException {
 
   @Test
   public void testPutKey() throws IOException {

Review Comment:
   Thanks for the detailed review, @kerneltime.
   The class name already describes the context of the test-cases so all its methods can implicitly inherit. Also, I just added a description to the class javadoc to describe the test intent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org