You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/01/10 02:18:46 UTC
Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Bugs: AMBARI-8917
https://issues.apache.org/jira/browse/AMBARI-8917
Repository: ambari
Description
-------
The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 055916b2b26ca6a8413a8f38317e5381f3d50ddb
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
Diff: https://reviews.apache.org/r/29788/diff/
Testing
-------
Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
Thanks,
Alejandro Fernandez
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/#review67571
-----------------------------------------------------------
ambari-server/src/main/python/ambari-server.py
<https://reviews.apache.org/r/29788/#comment111607>
Unrelated change that I wanted to fix here.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py
<https://reviews.apache.org/r/29788/#comment111608>
Improving namenode RU robustness while I'm at it.
- Alejandro Fernandez
On Jan. 10, 2015, 1:19 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29788/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 1:19 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-8917
> https://issues.apache.org/jira/browse/AMBARI-8917
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
> Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
> ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 055916b2b26ca6a8413a8f38317e5381f3d50ddb
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
>
> Diff: https://reviews.apache.org/r/29788/diff/
>
>
> Testing
> -------
>
> Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
>
> Unit test results are in progress.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/#review67574
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 9, 2015, 8:19 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29788/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 8:19 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-8917
> https://issues.apache.org/jira/browse/AMBARI-8917
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
> Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
> ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 055916b2b26ca6a8413a8f38317e5381f3d50ddb
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
>
> Diff: https://reviews.apache.org/r/29788/diff/
>
>
> Testing
> -------
>
> Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
>
> Unit test results are in progress.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/#review67724
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 12, 2015, 5:11 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29788/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2015, 5:11 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-8917
> https://issues.apache.org/jira/browse/AMBARI-8917
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
> Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
> ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
> ambari-server/src/test/python/TestAmbariServer.py 5f1fa388ff551222a534f4af1c00b34c070ec5fc
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
>
> Diff: https://reviews.apache.org/r/29788/diff/
>
>
> Testing
> -------
>
> Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:54.077s
> [INFO] Finished at: Mon Jan 12 14:03:55 PST 2015
> [INFO] Final Memory: 67M/830M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/#review67861
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 12, 2015, 10:11 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29788/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2015, 10:11 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-8917
> https://issues.apache.org/jira/browse/AMBARI-8917
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
> Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
> ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
> ambari-server/src/test/python/TestAmbariServer.py 5f1fa388ff551222a534f4af1c00b34c070ec5fc
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
>
> Diff: https://reviews.apache.org/r/29788/diff/
>
>
> Testing
> -------
>
> Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:54.077s
> [INFO] Finished at: Mon Jan 12 14:03:55 PST 2015
> [INFO] Final Memory: 67M/830M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/
-----------------------------------------------------------
(Updated Jan. 12, 2015, 10:11 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Changes
-------
Unit tests passed
Bugs: AMBARI-8917
https://issues.apache.org/jira/browse/AMBARI-8917
Repository: ambari
Description
-------
The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
ambari-server/src/test/python/TestAmbariServer.py 5f1fa388ff551222a534f4af1c00b34c070ec5fc
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
Diff: https://reviews.apache.org/r/29788/diff/
Testing (updated)
-------
Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:54.077s
[INFO] Finished at: Mon Jan 12 14:03:55 PST 2015
[INFO] Final Memory: 67M/830M
[INFO] ------------------------------------------------------------------------
Thanks,
Alejandro Fernandez
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/
-----------------------------------------------------------
(Updated Jan. 12, 2015, 7:13 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Changes
-------
Fixing unit tests.
Bugs: AMBARI-8917
https://issues.apache.org/jira/browse/AMBARI-8917
Repository: ambari
Description
-------
The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
ambari-server/src/test/python/TestAmbariServer.py 5f1fa388ff551222a534f4af1c00b34c070ec5fc
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
Diff: https://reviews.apache.org/r/29788/diff/
Testing (updated)
-------
Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
Unit tests before accepting patch 01b3af1b7d191019aafc0d8d670941548a7d4b14 (Ranger support) passed.
Will re-run unit tests on ABO
Thanks,
Alejandro Fernandez
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Jan. 12, 2015, 11:16 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py, line 91
> > <https://reviews.apache.org/r/29788/diff/1/?file=815633#file815633line91>
> >
> > don't we need the same thing for RM/NM components?
Not actually needed for RM and NM.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/#review67637
-----------------------------------------------------------
On Jan. 12, 2015, 7:13 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29788/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2015, 7:13 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-8917
> https://issues.apache.org/jira/browse/AMBARI-8917
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
> Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
> ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py e40f8c0ac4687052510e16639f683d0f19d315ac
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
> ambari-server/src/test/python/TestAmbariServer.py 5f1fa388ff551222a534f4af1c00b34c070ec5fc
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
>
> Diff: https://reviews.apache.org/r/29788/diff/
>
>
> Testing
> -------
>
> Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
>
> Unit tests before accepting patch 01b3af1b7d191019aafc0d8d670941548a7d4b14 (Ranger support) passed.
> Will re-run unit tests on ABO
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/#review67637
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
<https://reviews.apache.org/r/29788/#comment111709>
don't we need the same thing for RM/NM components?
- Dmitro Lisnichenko
On Jan. 10, 2015, 1:19 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29788/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 1:19 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-8917
> https://issues.apache.org/jira/browse/AMBARI-8917
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
> Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
> ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 055916b2b26ca6a8413a8f38317e5381f3d50ddb
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
>
> Diff: https://reviews.apache.org/r/29788/diff/
>
>
> Testing
> -------
>
> Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
>
> Unit test results are in progress.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/#review67648
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 9, 2015, 8:19 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29788/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 8:19 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-8917
> https://issues.apache.org/jira/browse/AMBARI-8917
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
> Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
> ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 055916b2b26ca6a8413a8f38317e5381f3d50ddb
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
>
> Diff: https://reviews.apache.org/r/29788/diff/
>
>
> Testing
> -------
>
> Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
>
> Unit test results are in progress.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 29788: Rolling Upgrade - prepare function to copy
tarballs based on new HDP version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29788/
-----------------------------------------------------------
(Updated Jan. 10, 2015, 1:19 a.m.)
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Bugs: AMBARI-8917
https://issues.apache.org/jira/browse/AMBARI-8917
Repository: ambari
Description
-------
The prepare_rolling_restart() functions call copy_tarballs_to_hdfs(), which gets the HDP version from the first component that matches the regex in the output of hdp-select, which is incorrect.
Instead of getting the first component, it should query a specific component, e.g., "hdp-select status hiveserver2"
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py 4f0dad3b308d325ec358a63c895e4708a6403943
ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py d80d37755bece5e172e75535f3c9a5d3a1fa9b6c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py 055916b2b26ca6a8413a8f38317e5381f3d50ddb
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py 9d53ea90b9e7e732a0ff0b8728cb12e898d3a4ac
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py a0e04abbe6c2eaede2ed8efbc79026bbc9d97135
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py 57bd37963047a7456d57a87f2032cd00a5cf8f9b
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 5dcc016b2fffd8af9334ecba7e342108ae0a8116
Diff: https://reviews.apache.org/r/29788/diff/
Testing (updated)
-------
Copied changed scripts to a new cluster, and restarted HiveServer2 and HistoryServer to make sure that the logs showed hdp-select using that component.
Unit test results are in progress.
Thanks,
Alejandro Fernandez