You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by iyerr3 <gi...@git.apache.org> on 2018/02/22 02:25:22 UTC

[GitHub] madlib pull request #238: MLP: Use array_upper to get the last array element

GitHub user iyerr3 opened a pull request:

    https://github.com/apache/madlib/pull/238

    MLP: Use array_upper to get the last array element

    JIRA: MADLIB-1209
    
    Postgresql arrays can be indexed in an arbitrary range. Hence,
    array_length is not necessarily the last element of the array. The
    array_upper function gives the index of the last element.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madlib/madlib bugfix/missing_array_length_gp4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #238
    
----
commit cdfb82c12c5598ca83afaa251604b5e0c8b8439f
Author: Rahul Iyer <ri...@...>
Date:   2018-02-21T23:58:24Z

    MLP: Use array_upper to get the last array element
    
    JIRA: MADLIB-1209
    
    Postgresql arrays can be indexed in an arbitrary range. Hence,
    array_length is not necessarily the last element of the array. The
    array_upper function gives the index of the last element.

----


---

[GitHub] madlib issue #238: MLP: Use array_upper to get the last array element

Posted by fmcquillan99 <gi...@git.apache.org>.

Github user fmcquillan99 commented on the issue:

    https://github.com/apache/madlib/pull/238
  
    LGTM


---

[GitHub] madlib issue #238: MLP: Use array_upper to get the last array element

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/238
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/356/



---

[GitHub] madlib pull request #238: MLP: Use array_upper to get the last array element

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/madlib/pull/238


---

[GitHub] madlib issue #238: MLP: Use array_upper to get the last array element

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/238
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/355/



---