You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Luciano Resende (JIRA)" <ji...@apache.org> on 2008/02/18 02:14:34 UTC
[jira] Created: (SHINDIG-78) Add sample svn:props and svn:ignore
sample files + script to set values in existent project files
Add sample svn:props and svn:ignore sample files + script to set values in existent project files
-------------------------------------------------------------------------------------------------
Key: SHINDIG-78
URL: https://issues.apache.org/jira/browse/SHINDIG-78
Project: Shindig
Issue Type: Bug
Reporter: Luciano Resende
Assignee: Brian McCallister
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-78) Add sample svn:props and svn:ignore
sample files + script to set values in existent project files
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende updated SHINDIG-78:
-----------------------------------
Attachment: lresende.shindig-78.patch
This patch introduce a sample svn:props and svn:ignores to be used for shindig project.
It also have a set_svn_properties script to be used for existent svn files.
> Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-78
> URL: https://issues.apache.org/jira/browse/SHINDIG-78
> Project: Shindig
> Issue Type: Bug
> Reporter: Luciano Resende
> Assignee: Brian McCallister
> Attachments: lresende.shindig-78.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SHINDIG-78) Add sample svn:props and svn:ignore sample files + script to set values in existent project files
Posted by Luciano Resende <lu...@gmail.com>.
No specific reasons, please go ahead and committ your updates.
On Sun, Mar 2, 2008 at 1:20 PM, Santiago Gala <sa...@gmail.com> wrote:
>
> El sáb, 01-03-2008 a las 16:06 -0800, Luciano Resende escribió:
>
> > I'm fine with the proposal. If others are OK I'll provide a patch and
> > would appreciate if someone could then run the "remove keyword script"
> > on the repository.
>
> I have already a patch. As I said, I discovered this while testing the
> use of git and git-svn for offline commit.
>
> I have actually two patches:
> * remove svn:keywords from the script, and add a line for removing them
> from the repository
> * revert the two files touched by keyword expansion (two jquery.js
> versions).
>
> I can run the scripts too and commit the results. I just wanted to know
> if there was a reason to activate svn:keywords or if it was, as I
> thought, a leftover in the script from other projects that are using it.
>
> Regards
> Santiago
>
>
>
> > On Sat, Mar 1, 2008 at 12:27 AM, Santiago Gala <sa...@gmail.com> wrote:
> > >
> > > El vie, 29-02-2008 a las 11:26 -0800, Luciano Resende (JIRA) escribió:
> > >
> > > > [ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573914#action_12573914 ]
> > > >
> > > > Luciano Resende commented on SHINDIG-78:
> > > > ----------------------------------------
> > > >
> > > > What's your suggestion here ? remove the usage of keywords ? or remove the property in special cases and/or file types ?
> > > >
> > >
> > > I noticed it in a strange way: I'm experiementing with the use of
> > > git-svn to track one of out repositories while keeping the whole
> > > history. When I diff'ed a standard svn working copy with a git-svn
> > > produced, I was not expecting any difference except for the .svn
> > > directories in the svn WC and the .git one at the head of the git one.
> > > But I found those two files. Strangely, the keyword expansion is done by
> > > the client code, and I guess the svn client code in git-svn is not
> > > compliant enough.
> > >
> > > That led me to search on it. I seem to remember that the best practices
> > > in the ASF re: keywords in source code was to remove them even before we
> > > migrated to subversion in 2004. At first I thought that they were coming
> > > from some external Google repository (actually they were coming from the
> > > jquery.org one). But the strange thing is that it was our script that
> > > added the svn:keyword to the typed files.
> > >
> > > My idea would be to remove the svn:keyword property from all the files
> > > in the repository, and from the script that does the tagging. Probably
> > > also to restore the jquery expansions, that shows us that we are using
> > > 1.2.1 instead of the last released 1.2.3 But I might be wrong and the
> > > svn:keywords stuff have a rationale, or practices be different in
> > > different areas of the ASF.
> > >
> > > What do you think?
> > >
> > > Regards
> > > Santiago
> > >
> > >
> > >
> > > > > Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> > > > > -------------------------------------------------------------------------------------------------
> > > > >
> > > > > Key: SHINDIG-78
> > > > > URL: https://issues.apache.org/jira/browse/SHINDIG-78
> > > > > Project: Shindig
> > > > > Issue Type: Bug
> > > > > Reporter: Luciano Resende
> > > > > Assignee: Brian McCallister
> > > > > Attachments: lresende.shindig-78.patch
> > > > >
> > > > >
> > > >
> > > >
> > > --
> > > Santiago Gala
> > > http://memojo.com/~sgala/blog/
> > >
> > >
> >
> >
> >
> --
> Santiago Gala
> http://memojo.com/~sgala/blog/
>
>
--
Luciano Resende
Apache Tuscany Committer
http://people.apache.org/~lresende
http://lresende.blogspot.com/
Re: [jira] Commented: (SHINDIG-78) Add sample svn:props and
svn:ignore sample files + script to set values in existent project files
Posted by Santiago Gala <sa...@gmail.com>.
El sáb, 01-03-2008 a las 16:06 -0800, Luciano Resende escribió:
> I'm fine with the proposal. If others are OK I'll provide a patch and
> would appreciate if someone could then run the "remove keyword script"
> on the repository.
I have already a patch. As I said, I discovered this while testing the
use of git and git-svn for offline commit.
I have actually two patches:
* remove svn:keywords from the script, and add a line for removing them
from the repository
* revert the two files touched by keyword expansion (two jquery.js
versions).
I can run the scripts too and commit the results. I just wanted to know
if there was a reason to activate svn:keywords or if it was, as I
thought, a leftover in the script from other projects that are using it.
Regards
Santiago
> On Sat, Mar 1, 2008 at 12:27 AM, Santiago Gala <sa...@gmail.com> wrote:
> >
> > El vie, 29-02-2008 a las 11:26 -0800, Luciano Resende (JIRA) escribió:
> >
> > > [ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573914#action_12573914 ]
> > >
> > > Luciano Resende commented on SHINDIG-78:
> > > ----------------------------------------
> > >
> > > What's your suggestion here ? remove the usage of keywords ? or remove the property in special cases and/or file types ?
> > >
> >
> > I noticed it in a strange way: I'm experiementing with the use of
> > git-svn to track one of out repositories while keeping the whole
> > history. When I diff'ed a standard svn working copy with a git-svn
> > produced, I was not expecting any difference except for the .svn
> > directories in the svn WC and the .git one at the head of the git one.
> > But I found those two files. Strangely, the keyword expansion is done by
> > the client code, and I guess the svn client code in git-svn is not
> > compliant enough.
> >
> > That led me to search on it. I seem to remember that the best practices
> > in the ASF re: keywords in source code was to remove them even before we
> > migrated to subversion in 2004. At first I thought that they were coming
> > from some external Google repository (actually they were coming from the
> > jquery.org one). But the strange thing is that it was our script that
> > added the svn:keyword to the typed files.
> >
> > My idea would be to remove the svn:keyword property from all the files
> > in the repository, and from the script that does the tagging. Probably
> > also to restore the jquery expansions, that shows us that we are using
> > 1.2.1 instead of the last released 1.2.3 But I might be wrong and the
> > svn:keywords stuff have a rationale, or practices be different in
> > different areas of the ASF.
> >
> > What do you think?
> >
> > Regards
> > Santiago
> >
> >
> >
> > > > Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> > > > -------------------------------------------------------------------------------------------------
> > > >
> > > > Key: SHINDIG-78
> > > > URL: https://issues.apache.org/jira/browse/SHINDIG-78
> > > > Project: Shindig
> > > > Issue Type: Bug
> > > > Reporter: Luciano Resende
> > > > Assignee: Brian McCallister
> > > > Attachments: lresende.shindig-78.patch
> > > >
> > > >
> > >
> > >
> > --
> > Santiago Gala
> > http://memojo.com/~sgala/blog/
> >
> >
>
>
>
--
Santiago Gala
http://memojo.com/~sgala/blog/
Re: [jira] Commented: (SHINDIG-78) Add sample svn:props and svn:ignore sample files + script to set values in existent project files
Posted by Luciano Resende <lu...@gmail.com>.
I'm fine with the proposal. If others are OK I'll provide a patch and
would appreciate if someone could then run the "remove keyword script"
on the repository.
On Sat, Mar 1, 2008 at 12:27 AM, Santiago Gala <sa...@gmail.com> wrote:
>
> El vie, 29-02-2008 a las 11:26 -0800, Luciano Resende (JIRA) escribió:
>
> > [ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573914#action_12573914 ]
> >
> > Luciano Resende commented on SHINDIG-78:
> > ----------------------------------------
> >
> > What's your suggestion here ? remove the usage of keywords ? or remove the property in special cases and/or file types ?
> >
>
> I noticed it in a strange way: I'm experiementing with the use of
> git-svn to track one of out repositories while keeping the whole
> history. When I diff'ed a standard svn working copy with a git-svn
> produced, I was not expecting any difference except for the .svn
> directories in the svn WC and the .git one at the head of the git one.
> But I found those two files. Strangely, the keyword expansion is done by
> the client code, and I guess the svn client code in git-svn is not
> compliant enough.
>
> That led me to search on it. I seem to remember that the best practices
> in the ASF re: keywords in source code was to remove them even before we
> migrated to subversion in 2004. At first I thought that they were coming
> from some external Google repository (actually they were coming from the
> jquery.org one). But the strange thing is that it was our script that
> added the svn:keyword to the typed files.
>
> My idea would be to remove the svn:keyword property from all the files
> in the repository, and from the script that does the tagging. Probably
> also to restore the jquery expansions, that shows us that we are using
> 1.2.1 instead of the last released 1.2.3 But I might be wrong and the
> svn:keywords stuff have a rationale, or practices be different in
> different areas of the ASF.
>
> What do you think?
>
> Regards
> Santiago
>
>
>
> > > Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> > > -------------------------------------------------------------------------------------------------
> > >
> > > Key: SHINDIG-78
> > > URL: https://issues.apache.org/jira/browse/SHINDIG-78
> > > Project: Shindig
> > > Issue Type: Bug
> > > Reporter: Luciano Resende
> > > Assignee: Brian McCallister
> > > Attachments: lresende.shindig-78.patch
> > >
> > >
> >
> >
> --
> Santiago Gala
> http://memojo.com/~sgala/blog/
>
>
--
Luciano Resende
Apache Tuscany Committer
http://people.apache.org/~lresende
http://lresende.blogspot.com/
Re: [jira] Commented: (SHINDIG-78) Add sample svn:props and
svn:ignore sample files + script to set values in existent project files
Posted by Santiago Gala <sa...@gmail.com>.
El vie, 29-02-2008 a las 11:26 -0800, Luciano Resende (JIRA) escribió:
> [ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573914#action_12573914 ]
>
> Luciano Resende commented on SHINDIG-78:
> ----------------------------------------
>
> What's your suggestion here ? remove the usage of keywords ? or remove the property in special cases and/or file types ?
>
I noticed it in a strange way: I'm experiementing with the use of
git-svn to track one of out repositories while keeping the whole
history. When I diff'ed a standard svn working copy with a git-svn
produced, I was not expecting any difference except for the .svn
directories in the svn WC and the .git one at the head of the git one.
But I found those two files. Strangely, the keyword expansion is done by
the client code, and I guess the svn client code in git-svn is not
compliant enough.
That led me to search on it. I seem to remember that the best practices
in the ASF re: keywords in source code was to remove them even before we
migrated to subversion in 2004. At first I thought that they were coming
from some external Google repository (actually they were coming from the
jquery.org one). But the strange thing is that it was our script that
added the svn:keyword to the typed files.
My idea would be to remove the svn:keyword property from all the files
in the repository, and from the script that does the tagging. Probably
also to restore the jquery expansions, that shows us that we are using
1.2.1 instead of the last released 1.2.3 But I might be wrong and the
svn:keywords stuff have a rationale, or practices be different in
different areas of the ASF.
What do you think?
Regards
Santiago
> > Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> > -------------------------------------------------------------------------------------------------
> >
> > Key: SHINDIG-78
> > URL: https://issues.apache.org/jira/browse/SHINDIG-78
> > Project: Shindig
> > Issue Type: Bug
> > Reporter: Luciano Resende
> > Assignee: Brian McCallister
> > Attachments: lresende.shindig-78.patch
> >
> >
>
>
--
Santiago Gala
http://memojo.com/~sgala/blog/
[jira] Commented: (SHINDIG-78) Add sample svn:props and svn:ignore
sample files + script to set values in existent project files
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573914#action_12573914 ]
Luciano Resende commented on SHINDIG-78:
----------------------------------------
What's your suggestion here ? remove the usage of keywords ? or remove the property in special cases and/or file types ?
> Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-78
> URL: https://issues.apache.org/jira/browse/SHINDIG-78
> Project: Shindig
> Issue Type: Bug
> Reporter: Luciano Resende
> Assignee: Brian McCallister
> Attachments: lresende.shindig-78.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SHINDIG-78) Add sample svn:props and svn:ignore
sample files + script to set values in existent project files
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner reopened SHINDIG-78:
---------------------------------
need to fix up keywords issue.
> Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-78
> URL: https://issues.apache.org/jira/browse/SHINDIG-78
> Project: Shindig
> Issue Type: Bug
> Reporter: Luciano Resende
> Assignee: Brian McCallister
> Attachments: lresende.shindig-78.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-78) Add sample svn:props and svn:ignore
sample files + script to set values in existent project files
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573845#action_12573845 ]
Santiago Gala commented on SHINDIG-78:
--------------------------------------
I found accidentally that this patch is enabling svn:keywords, which has actually affected, in commit r628730, to
features/opensocial-samplecontainer/caja-compatible-jquery.js
php/js/jquery.js
I think svn:keywords is nowadays usually frowned up at the ASF, in fact those two files have had their original data swept by the change:
-------- features/opensocial-samplecontainer/caja-compatible-jquery.js --------
index 4b5be1c..97fd7ce 100644
@@ -6,8 +6,8 @@
* Dual licensed under the MIT (MIT-LICENSE.txt)
* and GPL (GPL-LICENSE.txt) licenses.
*
- * $Date: 2007/09/28 $
- * $Rev: 3353 $
+ * $Date$
+ * $Rev$
*/
// Map over jQuery in case of overwrite
------------------------------- php/js/jquery.js -------------------------------
index 89e182e..e94fd3b 100755
@@ -10,8 +10,8 @@ if (window.dojo) {
* Dual licensed under the MIT (MIT-LICENSE.txt)
* and GPL (GPL-LICENSE.txt) licenses.
*
- * $Date: 2007-09-16 23:42:06 -0400 (Sun, 16 Sep 2007) $
- * $Rev: 3353 $
+ * $Date$
+ * $Rev$
*/
// Map over jQuery in case of overwrite
Those two files have been imported from the outside, ( http://en.wikipedia.org/wiki/JQuery , http://jqueryjs.googlecode.com/files/jquery-1.2.1.js )
I wonder if this makes sense. I can remove svn:keywords from the script, while keeping the other properties, and commit it both to etc and "fix" the tree, but I wanted to issue a heads up first, just in case the svn:keywords addition is intended and not a remain from an outside script.
> Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-78
> URL: https://issues.apache.org/jira/browse/SHINDIG-78
> Project: Shindig
> Issue Type: Bug
> Reporter: Luciano Resende
> Assignee: Brian McCallister
> Attachments: lresende.shindig-78.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-78) Add sample svn:props and svn:ignore
sample files + script to set values in existent project files
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-78.
---------------------------------
Resolution: Fixed
Patch applied with a bunch of fixes, enhancements..
Thanks!
> Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-78
> URL: https://issues.apache.org/jira/browse/SHINDIG-78
> Project: Shindig
> Issue Type: Bug
> Reporter: Luciano Resende
> Assignee: Brian McCallister
> Attachments: lresende.shindig-78.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (SHINDIG-78) Add sample svn:props and
svn:ignore sample files + script to set values in existent project files
Posted by Santiago Gala <sa...@gmail.com>.
El dom, 02-03-2008 a las 23:04 -0800, Paul Lindner (JIRA) escribió:
> [ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Paul Lindner resolved SHINDIG-78.
> ---------------------------------
>
> Resolution: Fixed
>
> I couldn't find any ASF discussion pro nor con for various keywords settings. The search did turn up a number of projects that do use standardized subversion configs to auto-set props, and those did have keywords with even more values than we are currently setting.
>
My question would be is the keywords are used. It does not matter if a
random, picked up the net and copied around sets up auto-set keyword
properties. If those properties are not expanded because there are no
anchors for them in the real files, which is the case here. Just two
files in the whole codebase got expanded, and those were imported with
their keywords.
I now that in most of jakarta keywords were "erradicated" sometime
before subversion arrived. They tend to pollute diffs and cause bogus
conflicts when used, and this is the reason why they are not used. I
seem to recall 2001 or 2002 when I last saw (cvs) keywords around.
In any case, your changes showed me how to resolve conflicts in the
git-svn scenario, and this is helpful in a sense. I still have a patch
to remove all keyword setting, which I think is helpful even if it is
only because it removes lines of the project, lines that are not being
used now.
> So marking this resolved for now, If there are compelling reasons to change this we'll reopen.
>
I don't think there are compelling reasons for treating it one way or
another. I tend to run from generated complexity, and having a script
injecting complexity in the code base looked bad to me. But, in any
case, it is bike-shedding.
Regards
Santiago
> Paul
>
>
> > Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> > -------------------------------------------------------------------------------------------------
> >
> > Key: SHINDIG-78
> > URL: https://issues.apache.org/jira/browse/SHINDIG-78
> > Project: Shindig
> > Issue Type: Bug
> > Reporter: Luciano Resende
> > Assignee: Brian McCallister
> > Attachments: lresende.shindig-78.patch
> >
> >
>
>
--
Santiago Gala
http://memojo.com/~sgala/blog/
[jira] Resolved: (SHINDIG-78) Add sample svn:props and svn:ignore
sample files + script to set values in existent project files
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-78.
---------------------------------
Resolution: Fixed
I couldn't find any ASF discussion pro nor con for various keywords settings. The search did turn up a number of projects that do use standardized subversion configs to auto-set props, and those did have keywords with even more values than we are currently setting.
So marking this resolved for now, If there are compelling reasons to change this we'll reopen.
Paul
> Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-78
> URL: https://issues.apache.org/jira/browse/SHINDIG-78
> Project: Shindig
> Issue Type: Bug
> Reporter: Luciano Resende
> Assignee: Brian McCallister
> Attachments: lresende.shindig-78.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.