You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@rya.apache.org by jdasch <gi...@git.apache.org> on 2017/09/08 16:30:54 UTC

[GitHub] incubator-rya pull request #224: RYA-361 Remove JCalendar library from merge...

Github user jdasch commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/224#discussion_r137833944
  
    --- Diff: extras/rya.export/export.client/src/main/java/org/apache/rya/export/client/conf/MergeConfigurationCLI.java ---
    @@ -149,7 +145,12 @@ public static MergeToolConfiguration createConfigurationFromFile(final File conf
                 throw new MergeConfigurationException("Failed to create a config based on the provided configuration.", JAXBe);
             }
         }
    -
    +    /**
    +     * returns the time option and makes it required.
    +     * This is for API and is not used internally as of v3.2.11
    +     * @return
    --- End diff --
    
    Add description to return and throws.  Make it clear that it returns a time or throws an exception when no time is configured because time is required.


---