[GitHub] [spark] ninadingole commented on a change in pull request #24196: [SPARK-27244][CORE] Redact Passwords While Using Option logConf=true

[GitBox <gi...@apache.org>]

ninadingole commented on a change in pull request #24196: [SPARK-27244][CORE] Redact Passwords While Using Option logConf=true
URL: https://github.com/apache/spark/pull/24196#discussion_r269081220
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/SparkConfSuite.scala
 ##########
 @@ -354,6 +354,16 @@ class SparkConfSuite extends SparkFunSuite with LocalSparkContext with ResetSyst
     }
   }
 
+  test("SPARK-27244 toDebugString should redact passwords") {
+    val EXPECTED_LOG = s"dummy.password=${Utils.REDACTION_REPLACEMENT_TEXT}"
+    val conf = new SparkConf().set("dummy.password", "dummy-password")
+    conf.validateSettings()
+
+    val debugString = conf.toDebugString
 
 Review comment:
   Is this the reason the build is failing? I will do the changes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org