You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by li...@apache.org on 2010/11/05 01:25:49 UTC
svn commit: r1031371 - in /shindig/trunk/java/gadgets/src:
main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java
test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java
Author: lindner
Date: Fri Nov 5 00:25:49 2010
New Revision: 1031371
URL: http://svn.apache.org/viewvc?rev=1031371&view=rev
Log:
SHINDIG-1418 | Modified Patch from Richard Atkins | Write detailed logging to debug, not warning or info
Modified:
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java
shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java
Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java?rev=1031371&r1=1031370&r2=1031371&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java Fri Nov 5 00:25:49 2010
@@ -98,8 +98,10 @@ public class OAuthResponseParams {
* Log a warning message that includes the details of the request.
*/
public void logDetailedWarning(String note) {
- if (LOG.isLoggable(Level.WARNING)) {
- LOG.log(Level.WARNING, note + '\n' + getDetails(null));
+ if (LOG.isLoggable(Level.FINE)) {
+ LOG.log(Level.FINE, note + '\n' + getDetails(null));
+ } else if (LOG.isLoggable(Level.WARNING)) {
+ LOG.log(Level.WARNING, note);
}
}
@@ -107,14 +109,18 @@ public class OAuthResponseParams {
* Log a warning message that includes the details of the request and the thrown exception.
*/
public void logDetailedWarning(String note, Throwable e) {
- if (LOG.isLoggable(Level.WARNING)) {
- LOG.log(Level.WARNING, note + '\n' + getDetails(e), e);
+ if (LOG.isLoggable(Level.FINE)) {
+ LOG.log(Level.FINE, note + '\n' + getDetails(e), e);
+ } else if (LOG.isLoggable(Level.WARNING)) {
+ LOG.log(Level.WARNING, note + ": " + e.getMessage());
}
}
public void logDetailedInfo(String note, Throwable e) {
- if (LOG.isLoggable(Level.INFO)) {
- LOG.log(Level.INFO, note + '\n' + getDetails(e), e);
+ if (LOG.isLoggable(Level.FINE)) {
+ LOG.log(Level.FINE, note + '\n' + getDetails(e), e);
+ } else if (LOG.isLoggable(Level.INFO)) {
+ LOG.log(Level.INFO, note + ": " + e.getMessage());
}
}
Modified: shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java?rev=1031371&r1=1031370&r2=1031371&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java (original)
+++ shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java Fri Nov 5 00:25:49 2010
@@ -117,6 +117,7 @@ public class OAuthRequestTest {
logRecords.add(arg0);
}
});
+ logger.setLevel(Level.FINE);
}
private OAuthCallbackGenerator createNullCallbackGenerator() {