[jira] [Comment Edited] (HBASE-18201) add UT and docs for DataBlockEncodingTool

["Kuan-Po Tseng (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526030#comment-16526030 ] 

Kuan-Po Tseng edited comment on HBASE-18201 at 6/28/18 7:40 AM:
----------------------------------------------------------------

-Yeah, that would be wrong, > 0 should be >=0. Will fix in next patch.-

We need to go through all KVs and check if there is one or more KVs that tagLength > 0，then useTag is true.


was (Author: brandboat):
Yeah, that would be wrong, > 0 should be >=0. Will fix in next patch.

> add UT and docs for DataBlockEncodingTool
> -----------------------------------------
>
>                 Key: HBASE-18201
>                 URL: https://issues.apache.org/jira/browse/HBASE-18201
>             Project: HBase
>          Issue Type: Task
>          Components: tooling
>            Reporter: Chia-Ping Tsai
>            Assignee: Kuan-Po Tseng
>            Priority: Minor
>              Labels: beginner
>         Attachments: HBASE-18201.master.001.patch, HBASE-18201.master.002.patch, HBASE-18201.master.002.patch, HBASE-18201.master.003.patch
>
>
> There is no example, documents, or tests for DataBlockEncodingTool. We should have it friendly if any use case exists. Otherwise, we should just get rid of it because DataBlockEncodingTool presumes that the implementation of cell returned from DataBlockEncoder is KeyValue. The presume may obstruct the cleanup of KeyValue references in the code base of read/write path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)