You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/18 13:16:43 UTC

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #395: make/clean: clean the OBJ directly if declare in subdirectory

v01d commented on pull request #395:
URL: https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694861664


   This feel a bit hackish. Shouldn't CLEAN take care of this?
   I think I know why this is needed: if you declare SRCS inside subdirectories from a Makefile.defs in another location, since CLEAN only considers objects in current directory, this indeed would clean them. But I think that we should fix CLEAN then instead, shouldn't we?
   
   Also, note that I think this is thought to be used to that every subdirectory with sources has a Makefile.defs, but if you want to build some third-party app which you can't modify (by adding the Make.defs everywhere), this isn't feasible.
   
   So, I think it is better to modify CLEAN IMHO.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org