You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Walter Chang (JIRA)" <ji...@apache.org> on 2009/12/16 04:47:18 UTC
[jira] Created: (THRIFT-652) Generated field name for strut is not
capitalized correctly
Generated field name for strut is not capitalized correctly
-----------------------------------------------------------
Key: THRIFT-652
URL: https://issues.apache.org/jira/browse/THRIFT-652
Project: Thrift
Issue Type: Bug
Components: Compiler (Haskell)
Affects Versions: 0.2
Environment: Mac OSX 10.6.2
Reporter: Walter Chang
Fix For: 0.3
Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-652) Generated field name for strut is not
capitalized correctly
Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Lavoie resolved THRIFT-652.
-------------------------------------
Assignee: Christian Lavoie
Fix Version/s: 0.5
Resolution: Fixed
This is fixed (and tested!) since my patches for THRIFT-918 were committed.
Walter, please let me know if that's not the case; please close this issue if my fixes work for you too.
> Generated field name for strut is not capitalized correctly
> -----------------------------------------------------------
>
> Key: THRIFT-652
> URL: https://issues.apache.org/jira/browse/THRIFT-652
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Compiler
> Affects Versions: 0.2
> Environment: Mac OSX 10.6.2
> Reporter: Walter Chang
> Assignee: Christian Lavoie
> Fix For: 0.5
>
> Attachments: t_hs_generator.patch
>
>
> Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-652) Generated field name for strut is
not capitalized correctly
Posted by "Sasha Rush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861081#action_12861081 ]
Sasha Rush commented on THRIFT-652:
-----------------------------------
Looks good to me. We always should decapitalize.
> Generated field name for strut is not capitalized correctly
> -----------------------------------------------------------
>
> Key: THRIFT-652
> URL: https://issues.apache.org/jira/browse/THRIFT-652
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Affects Versions: 0.2
> Environment: Mac OSX 10.6.2
> Reporter: Walter Chang
> Fix For: 0.3
>
> Attachments: t_hs_generator.patch
>
>
> Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-652) Generated field name for strut is
not capitalized correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861089#action_12861089 ]
Bryan Duxbury commented on THRIFT-652:
--------------------------------------
I don't actually understand what's supposed to happen here. The patch doesn't give me enough context to indicate clearly what's happening. Am I supposed to be getting rid of the decapitalize call, or adding it?
> Generated field name for strut is not capitalized correctly
> -----------------------------------------------------------
>
> Key: THRIFT-652
> URL: https://issues.apache.org/jira/browse/THRIFT-652
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Affects Versions: 0.2
> Environment: Mac OSX 10.6.2
> Reporter: Walter Chang
> Fix For: 0.3
>
> Attachments: t_hs_generator.patch
>
>
> Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-652) Generated field name for strut is
not capitalized correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860582#action_12860582 ]
Bryan Duxbury commented on THRIFT-652:
--------------------------------------
Anyone with Haskell experience want to sign off on this patch? Otherwise, I'll probably just commit it.
> Generated field name for strut is not capitalized correctly
> -----------------------------------------------------------
>
> Key: THRIFT-652
> URL: https://issues.apache.org/jira/browse/THRIFT-652
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Affects Versions: 0.2
> Environment: Mac OSX 10.6.2
> Reporter: Walter Chang
> Fix For: 0.3
>
> Attachments: t_hs_generator.patch
>
>
> Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-652) Generated field name for strut is not
capitalized correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-652:
---------------------------------
Fix Version/s: 0.4
(was: 0.3)
> Generated field name for strut is not capitalized correctly
> -----------------------------------------------------------
>
> Key: THRIFT-652
> URL: https://issues.apache.org/jira/browse/THRIFT-652
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Affects Versions: 0.2
> Environment: Mac OSX 10.6.2
> Reporter: Walter Chang
> Fix For: 0.4
>
> Attachments: t_hs_generator.patch
>
>
> Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-652) Generated field name for strut is not
capitalized correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-652:
---------------------------------
Fix Version/s: 0.5
(was: 0.4)
> Generated field name for strut is not capitalized correctly
> -----------------------------------------------------------
>
> Key: THRIFT-652
> URL: https://issues.apache.org/jira/browse/THRIFT-652
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Affects Versions: 0.2
> Environment: Mac OSX 10.6.2
> Reporter: Walter Chang
> Fix For: 0.5
>
> Attachments: t_hs_generator.patch
>
>
> Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-652) Generated field name for strut is not
capitalized correctly
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-652:
---------------------------------
Fix Version/s: (was: 0.5)
> Generated field name for strut is not capitalized correctly
> -----------------------------------------------------------
>
> Key: THRIFT-652
> URL: https://issues.apache.org/jira/browse/THRIFT-652
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Compiler
> Affects Versions: 0.2
> Environment: Mac OSX 10.6.2
> Reporter: Walter Chang
> Attachments: t_hs_generator.patch
>
>
> Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-652) Generated field name for strut is not
capitalized correctly
Posted by "Walter Chang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Walter Chang updated THRIFT-652:
--------------------------------
Attachment: t_hs_generator.patch
> Generated field name for strut is not capitalized correctly
> -----------------------------------------------------------
>
> Key: THRIFT-652
> URL: https://issues.apache.org/jira/browse/THRIFT-652
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Affects Versions: 0.2
> Environment: Mac OSX 10.6.2
> Reporter: Walter Chang
> Fix For: 0.3
>
> Attachments: t_hs_generator.patch
>
>
> Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.