[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #614: DISPATCH-1439 - Added two attributes to connection and one to router.

[GitBox <gi...@apache.org>]

ted-ross commented on a change in pull request #614: DISPATCH-1439 - Added two attributes to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343513338
 
 

 ##########
 File path: src/router_core/agent_connection.c
 ##########
 @@ -240,6 +245,17 @@ static void qdr_connection_insert_column_CT(qdr_core_t *core, qdr_connection_t *
         qd_compose_insert_string(body, text);
         break;
 
+    case QDR_CONNECTION_UPTIME_SECONDS:
+        qd_compose_insert_uint(body, core->uptime_ticks - conn->conn_uptime);
+        break;
+
+    case QDR_CONNECTION_LAST_DLV_SECONDS:
+        if (conn->is_delivery_sent)
+            qd_compose_insert_uint(body, core->uptime_ticks - conn->last_delivery_time);
+        else
+            qd_compose_insert_string(body, "-");
 
 Review comment:
   Adding hyphens to fields is the job of qdstat.  It should not be done here (I don't believe there is a precedent for it).  A better option is to insert a null value if there is no information to send.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org