You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/22 09:01:54 UTC

[GitHub] [flink] dawidwys commented on a change in pull request #16221: [FLINK-22881] Tasks are blocked while broadcasting stream status

dawidwys commented on a change in pull request #16221:
URL: https://github.com/apache/flink/pull/16221#discussion_r656022584



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
##########
@@ -652,11 +652,11 @@ private void processStreamStatus(StreamStatus streamStatus, int index) throws Ex
         }
     }
 
-    public final void processStreamStatus1(StreamStatus streamStatus) throws Exception {
+    public void processStreamStatus1(StreamStatus streamStatus) throws Exception {
         processStreamStatus(streamStatus, 0);
     }
 
-    public final void processStreamStatus2(StreamStatus streamStatus) throws Exception {
+    public void processStreamStatus2(StreamStatus streamStatus) throws Exception {

Review comment:
       You mean the entire commit? I think it makes sense, otherwise the operator will generate `StreamStatus` for every record.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org