You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/09/29 23:49:26 UTC
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19082
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Avoids using `hadoop fs` to recreate an Ozone bucket during snapshot
load, as this removes the encryption key.
Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
---
M testdata/bin/load-test-warehouse-snapshot.sh
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/19082/1
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11503/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 18:18:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Avoids using `hadoop fs` to recreate an Ozone bucket during snapshot
load, as this removes the encryption key.
Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Reviewed-on: http://gerrit.cloudera.org:8080/19082
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/load-test-warehouse-snapshot.sh
M tests/custom_cluster/test_exchange_delays.py
M tests/util/filesystem_utils.py
3 files changed, 11 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11494/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 05:47:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 3:
This makes sense to me. Can we test s3 with this change? I don't expect it to have any problem, but that is the other form factor that would use the logic in load-test-warehouse-snapshot.sh.
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 21:11:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19082
to look at the new patch set (#2).
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Avoids using `hadoop fs` to recreate an Ozone bucket during snapshot
load, as this removes the encryption key.
Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
---
M testdata/bin/load-test-warehouse-snapshot.sh
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/19082/2
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 3: Code-Review+2
This makes sense to me.
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 21:14:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11490/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 00:16:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19082/3/testdata/bin/load-test-warehouse-snapshot.sh
File testdata/bin/load-test-warehouse-snapshot.sh:
http://gerrit.cloudera.org:8080/#/c/19082/3/testdata/bin/load-test-warehouse-snapshot.sh@73
PS3, Line 73: echo "Removing existing ${TEST_WAREHOUSE_DIR} directory contents"
> S3 shouldn't hit this branch, it'll be in the if clause above.
Oh, nevermind!
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 21:14:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19082/3/testdata/bin/load-test-warehouse-snapshot.sh
File testdata/bin/load-test-warehouse-snapshot.sh:
http://gerrit.cloudera.org:8080/#/c/19082/3/testdata/bin/load-test-warehouse-snapshot.sh@73
PS3, Line 73: echo "Removing existing ${TEST_WAREHOUSE_DIR} directory contents"
S3 shouldn't hit this branch, it'll be in the if clause above.
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 21:12:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19082
to look at the new patch set (#3).
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Avoids using `hadoop fs` to recreate an Ozone bucket during snapshot
load, as this removes the encryption key.
Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
---
M testdata/bin/load-test-warehouse-snapshot.sh
M tests/custom_cluster/test_exchange_delays.py
M tests/util/filesystem_utils.py
3 files changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/19082/3
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8664/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 18:45:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 18:45:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19082 )
Change subject: IMPALA-9448: (Addendum) Avoid generic recreate for Ozone bucket
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31a3813fac6f2d68859ba7fed53b5c5a82502780
Gerrit-Change-Number: 19082
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 23:51:39 +0000
Gerrit-HasComments: No