You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "Matthias Bläsing (Jira)" <ji...@apache.org> on 2020/12/30 17:35:00 UTC
[jira] [Commented] (NETBEANS-5070) Partitial fix for NETBEANS-819
breaks terminal
[ https://issues.apache.org/jira/browse/NETBEANS-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256626#comment-17256626 ]
Matthias Bläsing commented on NETBEANS-5070:
--------------------------------------------
First result from analysis: we see an overflow here - the negative value results from a line of only \0 chars. These have a width of 0 and so we never advance and end the loop with an exception.
> Partitial fix for NETBEANS-819 breaks terminal
> ----------------------------------------------
>
> Key: NETBEANS-5070
> URL: https://issues.apache.org/jira/browse/NETBEANS-5070
> Project: NetBeans
> Issue Type: Bug
> Components: cnd - Terminalemulator
> Affects Versions: Next
> Reporter: Matthias Bläsing
> Assignee: Michal Hlavac
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 12.3
>
> Attachments: 99895991-55dd6080-2c41-11eb-9019-c7c96214a802.gif, Bildschirmfoto_2020-12-30_17-07-10.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The fix for shifted cursor in terminal windows commited by:
> [https://github.com/apache/netbeans/pull/2509]
> Breaks text selection (video provided by [~lkishalmi] ):
> !99895991-55dd6080-2c41-11eb-9019-c7c96214a802.gif!
> I also saw that behavior on windows and on linux I observed flaky behavior of the terminal and this is matched by exceptions:
> {quote}SEVERE [global]
> java.lang.ArrayIndexOutOfBoundsException: Index 134 out of bounds for length 134
> at java.desktop/sun.font.FontDesignMetrics.charsWidth(FontDesignMetrics.java:506)
> at org.netbeans.lib.terminalemulator.Line.stringWidth(Line.java:159)
> at org.netbeans.lib.terminalemulator.Sel.paint(Sel.java:407)
> at org.netbeans.lib.terminalemulator.Sel.access$000(Sel.java:71)
> at org.netbeans.lib.terminalemulator.Sel$2.visit(Sel.java:436)
> at org.netbeans.lib.terminalemulator.Buffer.visitLines(Buffer.java:205)
> at org.netbeans.lib.terminalemulator.Term.visitLines(Term.java:912)
> at org.netbeans.lib.terminalemulator.Sel.paint(Sel.java:434)
> at org.netbeans.lib.terminalemulator.Term.do_paint(Term.java:3175)
> at org.netbeans.lib.terminalemulator.Screen.paint(Screen.java:168)
> at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
> at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083)
> at java.desktop/javax.swing.JComponent.paintChildren(JComponent.java:907)
> at java.desktop/javax.swing.JComponent.paint(JComponent.java:1083){quote}
> So we either need a quick fix for this or we need to rollback the referenced commit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists