[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #166: Support deploy multiple shuffle servers in a single node

[GitBox <gi...@apache.org>]

xianjingfeng commented on code in PR #166:
URL: https://github.com/apache/incubator-uniffle/pull/166#discussion_r976250599


##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -158,6 +158,12 @@ public class RssBaseConf extends RssConf {
       .defaultValue(true)
       .withDescription("The switch for jvm metrics verbose");
 
+  public static final ConfigOption<String> RSS_SERVER_IP = ConfigOptions

Review Comment:
   I think use environment variable is not good in this case, because we need create mutil ShuffleServer in ut sometimes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org