You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "rohityadavcloud (via GitHub)" <gi...@apache.org> on 2023/07/21 07:32:55 UTC
[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #7761: vmware: improve solidfire storage plugin integration and fix cases
rohityadavcloud opened a new pull request, #7761:
URL: https://github.com/apache/cloudstack/pull/7761
This fixes the following cases in which Solidfire storage integration caused issues when using Solidfire datadisks with VMware:
1. Take Volume Snapshot of Solidfire data disk
2. Delete an active Instance with Solidfire data disk attached
3. Attach used existing Solidfire data disk to a running/stopped VM
4. Stop and Start an instance with Solidfire data disks attached
5. Expand disk by resizing Solidfire data disk by providing size
6. Expand disk by changing disk offering for the Solidfire data disk
Function | Operation | Description | Fix Status
-- | -- | -- | --
Create | Take Volume Snapshot | Take data disk volume snapshot on active instance | :white_check_mark:
Delete | Delete an active Instance | Delete an active Instance with attached 1:1 data disks | :white_check_mark:
Update | Attach used existing data disk | Attach a previous used data volume to a instance | :white_check_mark:
Update | Stop and Start a Instance | Stop and Start a Instance with attached 1:1 data disks | :white_check_mark:
Update | Resize Data volumen | Expand data disk on demand | :white_check_mark:
Update | Change disk offering for the data volumen | Expand data disk changing disk offering | :white_check_mark:
Update | Migrate data volume | Migrate a data volume between primaries storages Solidfire based | Unsupported feature
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [x] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
Tested in a ACS 4.17 adv zone env with VMware and Solidfire setup. Tested all the following cases:
<img width="1231" alt="Screenshot 2023-07-21 at 1 02 29 PM" src="https://github.com/apache/cloudstack/assets/95203/39ce7098-7d75-44f7-8086-1116bb4c77f3">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1645164409
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1673276139
@rohityadavcloud
is this ready for merge ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1649423485
@rohityadavcloud a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1650541506
<b>[SF] Trillian test result (tid-7163)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40683 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7761-t7163-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 75.75 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 51.38 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691253333
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270328240
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java:
##########
@@ -2826,6 +2826,9 @@ private ManagedObjectReference getVmfsDatastore(VmwareContext context, VmwareHyp
morDs = firstHostDatastoreSystemMO.findDatastoreByName(datastoreName);
if (morDs == null) {
morDs = firstHostDatastoreSystemMO.createVmfsDatastore(datastoreName, hostScsiDisk);
+ } else {
+ // in case of iSCSI/solidfire 1:1 VMFS datastore could be inaccessible
+ mountVmfsDatastore(new DatastoreMO(context, morDs), lstHosts);
Review Comment:
Workaround this checks and mounts inaccessible datastore. For others it will simply skip, for solidfire it will check and mount the datastore on the hosts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1652726495
<b>[SF] Trillian test result (tid-7173)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48780 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7761-t7173-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 76.57 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 55.40 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1649309220
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1651507776
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270363132
##########
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java:
##########
@@ -188,12 +192,25 @@ public boolean grantAccess(DataObject dataObject, Host host, DataStore dataStore
}
@Override
- public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore)
- {
+ public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore) {
if (dataObject == null || host == null || dataStore == null) {
return;
}
+ // Workaround: don't unplug iscsi lun when volume is attached to a VM
+ // This is regression workaround from upper layers which are calling
+ // ::releaseVmResources that calls the revoke on attached disk of a VM
+ if (dataObject.getType() == DataObjectType.VOLUME) {
Review Comment:
can be a separate method
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java:
##########
@@ -1113,6 +1113,9 @@ private long getVMSnapshotChainSize(VmwareContext context, VmwareHypervisorHost
DatastoreMO dsMo = new DatastoreMO(context, morDs);
HostDatastoreBrowserMO browserMo = dsMo.getHostDatastoreBrowserMO();
String datastorePath = (new DatastoreFile(dsMo.getName(), vmName)).getPath();
+ if (datastorePath.startsWith("[-iqn.")) { // ex. [-iqn.2010-01.com.solidfire:3p53.data-9999.97-0] i-2-9999-VM
Review Comment:
maybe we can have a method in one of the util classes to use it across
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -927,6 +927,7 @@ private Answer execute(ResizeVolumeCommand cmd) {
ClusterMO clusterMO = new ClusterMO(context, morCluster);
List<Pair<ManagedObjectReference, String>> lstHosts = clusterMO.getClusterHosts();
+ _storageProcessor.rescanAllHosts(context, lstHosts, true, true);
Review Comment:
I hope this won't cause an issue when there are many hosts in one cluster. Not sure if there is a way to limit rescanning to specific hosts or should we limit it to Solidfire volumes?
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1879,8 +1879,8 @@ public void prepare(VirtualMachineProfile vm, DeployDestination dest) throws Sto
throw new StorageAccessException(String.format("Unable to grant access to volume [%s] on host [%s].", volToString, host));
}
} else {
- // This might impact other managed storages, grant access for PowerFlex storage pool only
- if (pool.getPoolType() == Storage.StoragePoolType.PowerFlex) {
+ // This might impact other managed storages, grant access for PowerFlex and Iscsi/Solidfire storage pool only
+ if (pool.getPoolType() == Storage.StoragePoolType.PowerFlex || pool.getPoolType() == Storage.StoragePoolType.Iscsi) {
Review Comment:
```suggestion
if (List.of(Storage.StoragePoolType.PowerFlex, Storage.StoragePoolType.Iscsi).contains(pool.getPoolType())) {
```
Based on SolidFirePrimaryDataStoreLifeCycle class, iscsi check looks fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1273038025
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -927,6 +927,7 @@ private Answer execute(ResizeVolumeCommand cmd) {
ClusterMO clusterMO = new ClusterMO(context, morCluster);
List<Pair<ManagedObjectReference, String>> lstHosts = clusterMO.getClusterHosts();
+ _storageProcessor.rescanAllHosts(context, lstHosts, true, true);
Review Comment:
@shwstppr I had a code check, line no. 925 ensures this is run only in case of managed storage such as solidfire; so wouldn't affect non-managed storage such as nfs primary storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1692519799
<b>[SF] Trillian test result (tid-7531)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49474 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7761-t7531-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Failure` | 560.83 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270445981
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java:
##########
@@ -1113,6 +1113,9 @@ private long getVMSnapshotChainSize(VmwareContext context, VmwareHypervisorHost
DatastoreMO dsMo = new DatastoreMO(context, morDs);
HostDatastoreBrowserMO browserMo = dsMo.getHostDatastoreBrowserMO();
String datastorePath = (new DatastoreFile(dsMo.getName(), vmName)).getPath();
+ if (datastorePath.startsWith("[-iqn.")) { // ex. [-iqn.2010-01.com.solidfire:3p53.data-9999.97-0] i-2-9999-VM
Review Comment:
I'll attempt refactoring next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1645271589
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1692533110
<b>[SF] Trillian test result (tid-7532)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 47727 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7761-t7532-vmware-70u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Failure` | 585.85 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691173883
@NuxRo completed QA on this, against a community-supplied 4.17 Solidfire env (before he went on holidays). Now with @andrijapanicsb to finalise review. Thanks.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1650529015
<b>[SF] Trillian test result (tid-7161)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40195 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7761-t7161-xenserver-71.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 307.18 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 307.17 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.22 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1674582501
> Yes, @weizhouapache but @NuxRo needs to sign off with his testing. I'll change the PR to draft.
Ok thanks @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1674580975
Yes, @weizhouapache but @NuxRo needs to sign off with his testing. I'll change the PR to draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691340148
@blueorangutan test rocky8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1273042184
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -927,6 +927,7 @@ private Answer execute(ResizeVolumeCommand cmd) {
ClusterMO clusterMO = new ClusterMO(context, morCluster);
List<Pair<ManagedObjectReference, String>> lstHosts = clusterMO.getClusterHosts();
+ _storageProcessor.rescanAllHosts(context, lstHosts, true, true);
Review Comment:
I'll still add a check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270447014
##########
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java:
##########
@@ -188,12 +192,25 @@ public boolean grantAccess(DataObject dataObject, Host host, DataStore dataStore
}
@Override
- public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore)
- {
+ public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore) {
if (dataObject == null || host == null || dataStore == null) {
return;
}
+ // Workaround: don't unplug iscsi lun when volume is attached to a VM
+ // This is regression workaround from upper layers which are calling
+ // ::releaseVmResources that calls the revoke on attached disk of a VM
+ if (dataObject.getType() == DataObjectType.VOLUME) {
Review Comment:
Can be done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1645212631
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7761](https://app.codecov.io/gh/apache/cloudstack/pull/7761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d4a0a15) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/80ca3acf1574612974a9340dd94954916c2a9aad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (80ca3ac) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.18 #7761 +/- ##
============================================
- Coverage 13.02% 13.02% -0.01%
Complexity 9028 9028
============================================
Files 2720 2720
Lines 256992 257004 +12
Branches 40078 40082 +4
============================================
Hits 33463 33463
- Misses 219330 219341 +11
- Partials 4199 4200 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/cloudstack/pull/7761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...stack/engine/orchestration/VolumeOrchestrator.java](https://app.codecov.io/gh/apache/cloudstack/pull/7761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vVm9sdW1lT3JjaGVzdHJhdG9yLmphdmE=) | `1.91% <0.00%> (ø)` | |
| [...visor/vmware/manager/VmwareStorageManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvbWFuYWdlci9WbXdhcmVTdG9yYWdlTWFuYWdlckltcGwuamF2YQ==) | `6.22% <0.00%> (-0.02%)` | :arrow_down: |
| [...oud/hypervisor/vmware/resource/VmwareResource.java](https://app.codecov.io/gh/apache/cloudstack/pull/7761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvcmVzb3VyY2UvVm13YXJlUmVzb3VyY2UuamF2YQ==) | `4.50% <0.00%> (-0.01%)` | :arrow_down: |
| [...cloud/storage/resource/VmwareStorageProcessor.java](https://app.codecov.io/gh/apache/cloudstack/pull/7761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvc3RvcmFnZS9yZXNvdXJjZS9WbXdhcmVTdG9yYWdlUHJvY2Vzc29yLmphdmE=) | `0.32% <0.00%> (-0.01%)` | :arrow_down: |
| [...astore/driver/SolidFirePrimaryDataStoreDriver.java](https://app.codecov.io/gh/apache/cloudstack/pull/7761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zb2xpZGZpcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9kYXRhc3RvcmUvZHJpdmVyL1NvbGlkRmlyZVByaW1hcnlEYXRhU3RvcmVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1649306250
Thanks @shwstppr @DaanHoogland @weizhouapache @harikrishna-patnala I've incorporated your review and refactored places that wouldn't entagle the wires too much and added unit tests for cases. Rest I've re-tested all cases again:
<img width="1233" alt="Screenshot 2023-07-25 at 1 17 09 PM" src="https://github.com/apache/cloudstack/assets/95203/63c56bc1-7653-4ffe-91ec-bc222c46c0c8">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1649307376
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1649459358
<b>[SF] Trillian Build Failed (tid-7162)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270326730
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java:
##########
@@ -1113,6 +1113,9 @@ private long getVMSnapshotChainSize(VmwareContext context, VmwareHypervisorHost
DatastoreMO dsMo = new DatastoreMO(context, morDs);
HostDatastoreBrowserMO browserMo = dsMo.getHostDatastoreBrowserMO();
String datastorePath = (new DatastoreFile(dsMo.getName(), vmName)).getPath();
+ if (datastorePath.startsWith("[-iqn.")) { // ex. [-iqn.2010-01.com.solidfire:3p53.data-9999.97-0] i-2-9999-VM
Review Comment:
Note: similar code exists in the caller that checks for the specific datastore string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1645243023
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1645294364
@rohityadavcloud a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691314201
@blueorangutan test ubuntu22 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1273045111
##########
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java:
##########
@@ -188,12 +192,25 @@ public boolean grantAccess(DataObject dataObject, Host host, DataStore dataStore
}
@Override
- public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore)
- {
+ public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore) {
if (dataObject == null || host == null || dataStore == null) {
return;
}
+ // Workaround: don't unplug iscsi lun when volume is attached to a VM
+ // This is regression workaround from upper layers which are calling
+ // ::releaseVmResources that calls the revoke on attached disk of a VM
+ if (dataObject.getType() == DataObjectType.VOLUME) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1649423137
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691316723
@weizhouapache [SF] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270327322
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -927,6 +927,7 @@ private Answer execute(ResizeVolumeCommand cmd) {
ClusterMO clusterMO = new ClusterMO(context, morCluster);
List<Pair<ManagedObjectReference, String>> lstHosts = clusterMO.getClusterHosts();
+ _storageProcessor.rescanAllHosts(context, lstHosts, true, true);
Review Comment:
There's some issue with VMware not able to detect resized/modification in the LUN size, this is a workaround for VMware to see an updated/resized LUN. Otherwise VMFS datastore doesn't see it can resize and silently fails. This could be a bug in VMware or the Solidfire LUN integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1645291821
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1651511378
@rohityadavcloud a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1651508214
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270446806
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -927,6 +927,7 @@ private Answer execute(ResizeVolumeCommand cmd) {
ClusterMO clusterMO = new ClusterMO(context, morCluster);
List<Pair<ManagedObjectReference, String>> lstHosts = clusterMO.getClusterHosts();
+ _storageProcessor.rescanAllHosts(context, lstHosts, true, true);
Review Comment:
I think we'll need to rescan all the hosts in the cluster; yes that could make the process very slow. If necessary I can add in some logic to scan only when datastore is iscsi (start with -iqn...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1645126851
great work @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1645166152
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1646275177
<b>[SF] Trillian test result (tid-7135)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43125 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7761-t7135-xenserver-71.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 309.66 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1646353371
<b>[SF] Trillian test result (tid-7136)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51697 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7761-t7136-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_vm_on_specific_host | `Error` | 18.77 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 3602.92 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 4.42 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.45 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 2.33 | test_vm_deployment_planner.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1652512522
<b>[SF] Trillian test result (tid-7171)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37558 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7761-t7171-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691273489
@blueorangutan test rocky8 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691342427
@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691275661
@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1682120754
cc @NuxRo
plaese kindly approve it if it is tested good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1651544098
<b>[SF] Trillian Build Failed (tid-7172)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270329271
##########
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java:
##########
@@ -188,12 +192,25 @@ public boolean grantAccess(DataObject dataObject, Host host, DataStore dataStore
}
@Override
- public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore)
- {
+ public void revokeAccess(DataObject dataObject, Host host, DataStore dataStore) {
if (dataObject == null || host == null || dataStore == null) {
return;
}
+ // Workaround: don't unplug iscsi lun when volume is attached to a VM
+ // This is regression workaround from upper layers which are calling
+ // ::releaseVmResources that calls the revoke on attached disk of a VM
+ if (dataObject.getType() == DataObjectType.VOLUME) {
Review Comment:
Explained the workaround in the comments, prior to ScaleIO integration the revokeAccess() wasn't called by upper layers say when a VM is stopped. We don't want to eject/remove the LUN from VMware unless the volume is detached or the VM/volume is to be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270327842
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1879,8 +1879,8 @@ public void prepare(VirtualMachineProfile vm, DeployDestination dest) throws Sto
throw new StorageAccessException(String.format("Unable to grant access to volume [%s] on host [%s].", volToString, host));
}
} else {
- // This might impact other managed storages, grant access for PowerFlex storage pool only
- if (pool.getPoolType() == Storage.StoragePoolType.PowerFlex) {
+ // This might impact other managed storages, grant access for PowerFlex and Iscsi/Solidfire storage pool only
+ if (pool.getPoolType() == Storage.StoragePoolType.PowerFlex || pool.getPoolType() == Storage.StoragePoolType.Iscsi) {
Review Comment:
This is to workaround the issue mentioned in the solidfire plugin, to grant access (that LUN is accessible to vmware).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1646314893
<b>[SF] Trillian test result (tid-7137)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7761-t7137-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 76.80 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 53.63 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.84 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1649385409
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
URL: https://github.com/apache/cloudstack/pull/7761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270327322
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -927,6 +927,7 @@ private Answer execute(ResizeVolumeCommand cmd) {
ClusterMO clusterMO = new ClusterMO(context, morCluster);
List<Pair<ManagedObjectReference, String>> lstHosts = clusterMO.getClusterHosts();
+ _storageProcessor.rescanAllHosts(context, lstHosts, true, true);
Review Comment:
There's some issue with VMware not able to detect resized/modification in the LUN size, this is a workaround for VMware to see an updated/resized LUN. Otherwise VMFS datastore doesn't see it can resize and silently fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691176134
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org