You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Sylvain Wallez <sy...@bluxte.net> on 2011/01/03 18:31:57 UTC
Re: XMLSerializer.java why not implements CacheableProcessingComponent
Le 30/12/10 13:08, Thorsten Scherler a écrit :
> Hi all,
>
> I wonder is there a reason why nobody did
>
> -public class XMLSerializer extends EncodingSerializer {
> +public class XMLSerializer extends EncodingSerializer implements
> CacheableProcessingComponent {
>
> I am doing some caching enhancement for a client and using the profiler
> I found out that my 100% cacheable page did not return 304. So I
> stumbled upon the above.
>
> When I make the XMLSerializer implementing CacheableProcessingComponent
> the whole pipeline is returning 304 which I am looking for that the
> status is for the response.
>
> Without the above patch I always get a 200 since the serializer is not
> cacheable hence the whole pipe.
>
> Is there an obvious reason that I am not seeing why the serializer
> should not be cacheable?
This is obviously an error, and the "other" serializer in
org.apache.cocoon.serialization.XMLSerializer is cacheable.
Sylvain
--
Sylvain Wallez - http://bluxte.net
Re: XMLSerializer.java why not implements
CacheableProcessingComponent
Posted by Thorsten Scherler <sc...@gmail.com>.
On Mon, 2011-01-03 at 18:31 +0100, Sylvain Wallez wrote:
> Le 30/12/10 13:08, Thorsten Scherler a écrit :
> > Hi all,
> >
> > I wonder is there a reason why nobody did
> >
> > -public class XMLSerializer extends EncodingSerializer {
> > +public class XMLSerializer extends EncodingSerializer implements
> > CacheableProcessingComponent {
> >
> > I am doing some caching enhancement for a client and using the profiler
> > I found out that my 100% cacheable page did not return 304. So I
> > stumbled upon the above.
> >
> > When I make the XMLSerializer implementing CacheableProcessingComponent
> > the whole pipeline is returning 304 which I am looking for that the
> > status is for the response.
> >
> > Without the above patch I always get a 200 since the serializer is not
> > cacheable hence the whole pipe.
> >
> > Is there an obvious reason that I am not seeing why the serializer
> > should not be cacheable?
>
> This is obviously an error, and the "other" serializer in
> org.apache.cocoon.serialization.XMLSerializer is cacheable.
Thanks for your feedback I will commit that ASAP.
salu2
--
Thorsten Scherler <thorsten.at.apache.org>
codeBusters S.L. - web based systems
<consulting, training and solutions>
http://www.codebusters.es/