You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/09/21 03:40:37 UTC
[native-toolchain-CR] IMPALA-11599: Build gdb with the OS compiler
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19022
Change subject: IMPALA-11599: Build gdb with the OS compiler
......................................................................
IMPALA-11599: Build gdb with the OS compiler
With the switch to a newer GDB that accompanied
the GCC 10.4 upgrade, GDB now has a dependency on
libstdc++. gdb from the GCC 10.4 toolchain fails
on Centos 7 with messages like:
gdb: /../lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by gdb)
gdb: /../lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by gdb)
gdb: /../lib64/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by gdb)
Checking the gdb binary, it's RPATH is not setup
correctly, so it is not able to find the libstdc++
that ships with GCC 10 and Centos 7's libstdc++
is too old.
Since Impala only needs the gdb binary and setting the
RPATH is difficult for gdb, this switches to building
gdb with the OS compilers / libstdc++. That avoids the
need to fix the RPATH.
Testing:
- Ran build, downloaded the binary on Centos 7, verified
it ran properly
Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
---
M buildall.sh
M functions.sh
M init-compiler.sh
3 files changed, 16 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/22/19022/1
--
To view, visit http://gerrit.cloudera.org:8080/19022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
Gerrit-Change-Number: 19022
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-11599: Build gdb with the OS compiler
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19022 )
Change subject: IMPALA-11599: Build gdb with the OS compiler
......................................................................
Patch Set 2: Verified+1
The native-toolchain build passed, I'm putting together the Impala side change. Since this doesn't change any versions, I'm going to go ahead and merge it.
--
To view, visit http://gerrit.cloudera.org:8080/19022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
Gerrit-Change-Number: 19022
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Sep 2022 17:16:32 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11599: Build gdb with the OS compiler
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19022 )
Change subject: IMPALA-11599: Build gdb with the OS compiler
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
Gerrit-Change-Number: 19022
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Sep 2022 07:53:14 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11599: Build gdb with the OS compiler
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19022 )
Change subject: IMPALA-11599: Build gdb with the OS compiler
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19022/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19022/1//COMMIT_MSG@16
PS1, Line 16: it's
nit: its
--
To view, visit http://gerrit.cloudera.org:8080/19022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
Gerrit-Change-Number: 19022
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Sep 2022 04:00:56 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11599: Build gdb with the OS compiler
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19022 )
Change subject: IMPALA-11599: Build gdb with the OS compiler
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19022/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19022/1//COMMIT_MSG@16
PS1, Line 16: it's
> nit: its
Done
--
To view, visit http://gerrit.cloudera.org:8080/19022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
Gerrit-Change-Number: 19022
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Sep 2022 04:54:13 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11599: Build gdb with the OS compiler
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19022
to look at the new patch set (#2).
Change subject: IMPALA-11599: Build gdb with the OS compiler
......................................................................
IMPALA-11599: Build gdb with the OS compiler
With the switch to a newer GDB that accompanied
the GCC 10.4 upgrade, GDB now has a dependency on
libstdc++. gdb from the GCC 10.4 toolchain fails
on Centos 7 with messages like:
gdb: /../lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by gdb)
gdb: /../lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by gdb)
gdb: /../lib64/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by gdb)
Checking the gdb binary, its RPATH is not setup
correctly, so it is not able to find the libstdc++
that ships with GCC 10 and Centos 7's libstdc++
is too old.
Since Impala only needs the gdb binary and setting the
RPATH is difficult for gdb, this switches to building
gdb with the OS compilers / libstdc++. That avoids the
need to fix the RPATH.
Testing:
- Ran build, downloaded the binary on Centos 7, verified
it ran properly
Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
---
M buildall.sh
M functions.sh
M init-compiler.sh
3 files changed, 16 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/22/19022/2
--
To view, visit http://gerrit.cloudera.org:8080/19022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
Gerrit-Change-Number: 19022
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-11599: Build gdb with the OS compiler
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19022 )
Change subject: IMPALA-11599: Build gdb with the OS compiler
......................................................................
IMPALA-11599: Build gdb with the OS compiler
With the switch to a newer GDB that accompanied
the GCC 10.4 upgrade, GDB now has a dependency on
libstdc++. gdb from the GCC 10.4 toolchain fails
on Centos 7 with messages like:
gdb: /../lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by gdb)
gdb: /../lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by gdb)
gdb: /../lib64/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by gdb)
Checking the gdb binary, its RPATH is not setup
correctly, so it is not able to find the libstdc++
that ships with GCC 10 and Centos 7's libstdc++
is too old.
Since Impala only needs the gdb binary and setting the
RPATH is difficult for gdb, this switches to building
gdb with the OS compilers / libstdc++. That avoids the
need to fix the RPATH.
Testing:
- Ran build, downloaded the binary on Centos 7, verified
it ran properly
Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
Reviewed-on: http://gerrit.cloudera.org:8080/19022
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
M functions.sh
M init-compiler.sh
3 files changed, 16 insertions(+), 13 deletions(-)
Approvals:
Wenzhe Zhou: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b794f3f28e3932c08ced0952bc1ba342c3dc0f6
Gerrit-Change-Number: 19022
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>