[GitHub] [trafficserver] ywkaras commented on a change in pull request #6692: Fix deprecated-copy warning in cache tool

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #6692:
URL: https://github.com/apache/trafficserver/pull/6692#discussion_r412242666



##########
File path: src/traffic_cache_tool/CacheTool.cc
##########
@@ -255,6 +255,8 @@ class VolumeAllocator
       : _config(config), _size(size), _deficit(deficit), _shares(shares)
     {
     }
+    V(const V &v) : _config(v._config), _size(v._size), _deficit(v._deficit), _shares(v._shares) {}

Review comment:
       Hmm, it seems like this could just be:
   ```
   V(const V &v) = default;
   ```
   But it also seem like you could just let both the copy constructor and the copy assign be defined implicitly.  @SolidWallOfCode did you originally write this code, what's the dealio?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org