[GitHub] [deltaspike] gpetracek commented on a change in pull request #113: Avoid NPE in WindowContextImpl

[GitBox <gi...@apache.org>]

gpetracek commented on a change in pull request #113:
URL: https://github.com/apache/deltaspike/pull/113#discussion_r494849017



##########
File path: deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/scope/window/WindowContextImpl.java
##########
@@ -82,6 +82,11 @@ public void activateWindow(String windowId)
     @Override
     public String getCurrentWindowId()
     {
+        if (windowHolder == null)

Review comment:
       it sounds like a broken setup, because a proxy to the windowHolder gets used. the init code (including the lookup of the proxy) is part of the startup process - see: https://github.com/apache/deltaspike/blob/master/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/scope/DeltaSpikeContextExtension.java#L91
   
   that means ds isn't in a valid state in this case and you might face further issues.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org