[GitHub] [spark] viirya commented on a diff in pull request #36939: [SPARK-39542][YARN] Improve YARN client mode to support IPv6

[GitBox <gi...@apache.org>]

viirya commented on code in PR #36939:
URL: https://github.com/apache/spark/pull/36939#discussion_r902816214


##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -313,7 +313,7 @@ private[spark] class ApplicationMaster(
           sparkConf.get(DRIVER_PORT)),
         YarnSchedulerBackend.ENDPOINT_NAME)
       // The client-mode AM doesn't listen for incoming connections, so report an invalid port.
-      registerAM(Utils.localHostName, -1, sparkConf,
+      registerAM(Utils.localHostNameForURI(), -1, sparkConf,

Review Comment:
   `localHostName` not work for ipv6? I saw its code comment `In case of IPv6, getHostAddress may return '0:0:0:0:0:0:0:1'.`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org