You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/07/01 14:53:09 UTC
Review Request 12207: Cloudstack-3299 incorrect arguments sent to the script
createIpalias in case of vmware,
Cloudstack-3240 corrected a mistake in the script name.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12207/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Bugs: Cloudstack-3240 and Cloudstack-3299
Repository: cloudstack-git
Description
-------
Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware,
Cloudstack-3240 corrected a mistake in the script name.
Diffs
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 286eb48
Diff: https://reviews.apache.org/r/12207/diff/
Testing
-------
Thanks,
bharat kumar
Re: Review Request 12207: Cloudstack-3299 incorrect arguments sent to the
script createIpalias in case of vmware,
Cloudstack-3240 corrected a mistake in the script name.
Posted by bharat kumar <bh...@citrix.com>.
> On July 2, 2013, 6:26 a.m., Abhinandan Prateek wrote:
> > Has this been tested ?
I did not test the fix, I don't have access to the vmware setup as of now.
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12207/#review22646
-----------------------------------------------------------
On July 1, 2013, 12:53 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12207/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 12:53 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: Cloudstack-3240 and Cloudstack-3299
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware,
> Cloudstack-3240 corrected a mistake in the script name.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 286eb48
>
> Diff: https://reviews.apache.org/r/12207/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 12207: Cloudstack-3299 incorrect arguments sent to the
script createIpalias in case of vmware,
Cloudstack-3240 corrected a mistake in the script name.
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12207/#review22646
-----------------------------------------------------------
Has this been tested ?
- Abhinandan Prateek
On July 1, 2013, 12:53 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12207/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 12:53 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: Cloudstack-3240 and Cloudstack-3299
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware,
> Cloudstack-3240 corrected a mistake in the script name.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 286eb48
>
> Diff: https://reviews.apache.org/r/12207/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 12207: Cloudstack-3299 incorrect arguments sent to the
script createIpalias in case of vmware,
Cloudstack-3240 corrected a mistake in the script name.
Posted by bharat kumar <bh...@citrix.com>.
> On July 2, 2013, 6:28 a.m., Abhinandan Prateek wrote:
> > Also for two bug fixes submit different reviews or if they are duplicate mark these as such.
linked the issues
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12207/#review22647
-----------------------------------------------------------
On July 1, 2013, 12:53 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12207/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 12:53 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: Cloudstack-3240 and Cloudstack-3299
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware,
> Cloudstack-3240 corrected a mistake in the script name.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 286eb48
>
> Diff: https://reviews.apache.org/r/12207/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 12207: Cloudstack-3299 incorrect arguments sent to the
script createIpalias in case of vmware,
Cloudstack-3240 corrected a mistake in the script name.
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12207/#review22647
-----------------------------------------------------------
Also for two bug fixes submit different reviews or if they are duplicate mark these as such.
- Abhinandan Prateek
On July 1, 2013, 12:53 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12207/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 12:53 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: Cloudstack-3240 and Cloudstack-3299
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Cloudstack-3299 incorrect arguments sent to the script createIpalias in case of vmware,
> Cloudstack-3240 corrected a mistake in the script name.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 286eb48
>
> Diff: https://reviews.apache.org/r/12207/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>