You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apsaltis <gi...@git.apache.org> on 2017/01/26 05:58:47 UTC

[GitHub] nifi pull request #1447: NIFI-2615 Adding GetTCP processor

GitHub user apsaltis opened a pull request:

    https://github.com/apache/nifi/pull/1447

    NIFI-2615 Adding GetTCP processor

    This P/R is to address the code documentation issues that caused checkstyle failures and the build to fail after the changes from #1433 were merged. I have run a build with this using the -Pcontrib-check profile and will run all future contributions with this profile enabled prior to P/R submission. Thanks you @alopresto for catching these violations and starting the fixes. 
    
    This nar provides a GetTCP processor in a generic TCP bundle. This is an update based on the previous P/R [1] feedback for this nar.
    
    [1] #1433
    [2] #1434 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apsaltis/nifi NIFI-2615

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1447.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1447
    
----
commit 0c1778b944b0efcd8480867274ca47fc8f816798
Author: Andrew Psaltis <ps...@gmail.com>
Date:   2017-01-26T05:48:35Z

    Addressing documentation issues that caused checkstyle failures and the build to fail

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1447: NIFI-2615 Adding GetTCP processor

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1447


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1447: NIFI-2615 Adding GetTCP processor

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1447
  
    Reviewed, fixed typos, merged. Thanks @apsaltis . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---