[GitHub] [beam] apilloud commented on a change in pull request #14372: [BEAM-12014] Add BIGNUMERIC support in BEAM

[GitBox <gi...@apache.org>]

apilloud commented on a change in pull request #14372:
URL: https://github.com/apache/beam/pull/14372#discussion_r604378234



##########
File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryAvroUtilsTest.java
##########
@@ -99,28 +103,30 @@ public void testConvertGenericRecordToTableRow() throws Exception {
     // type. AvroCoder can't apply logical types to Schemas directly, so we need to get the
     // Schema for the Bird class defined below, then replace the field used to test NUMERIC with
     // a field that has the appropriate Schema.
-    BigDecimal birthdayMoney = new BigDecimal("123456789.123456789");
-    Schema birthdayMoneySchema = Schema.create(Type.BYTES);
-    LogicalType birthdayMoneyLogicalType =
-        LogicalTypes.decimal(birthdayMoney.precision(), birthdayMoney.scale());
+    BigDecimal bigDecimal =
+        new BigDecimal(
+            "578960446186580977117854925043439539266.34992332820282019728792003956564819967");

Review comment:
       If you're going to use this for both NUMERIC and BIGNUMERIC tests, can you keep the value within the supported range for both? I think the prior value `123456789.123456789` would work fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org